enable PSR1.Classes.ClassDeclaration and PSR1.Files.SideEffects

This commit is contained in:
Spine
2024-12-20 09:39:21 +01:00
parent 5e3cfb2525
commit 683228acc2
133 changed files with 1941 additions and 1662 deletions
+17 -15
View File
@@ -1,9 +1,11 @@
<?php
namespace Gazelle;
use PHPUnit\Framework\TestCase;
class UserCreateTest extends TestCase {
protected Gazelle\User $user;
protected User $user;
public function tearDown(): void {
if (isset($this->user)) {
@@ -17,7 +19,7 @@ class UserCreateTest extends TestCase {
$password = randomString(40);
$adminComment = 'Created by tests/phpunit/UserCreateTest.php';
$this->user = (new \Gazelle\UserCreator())
$this->user = (new UserCreator())
->setUsername($name)
->setEmail($email)
->setPassword($password)
@@ -30,7 +32,7 @@ class UserCreateTest extends TestCase {
$this->assertTrue($this->user->isUnconfirmed(), 'user-create-unconfirmed');
$this->assertStringStartsWith(
'static/styles/apollostage/style.css?v=',
(new Gazelle\User\Stylesheet($this->user))->cssUrl(),
(new User\Stylesheet($this->user))->cssUrl(),
'user-create-stylesheet'
);
@@ -45,29 +47,29 @@ class UserCreateTest extends TestCase {
}
public function testLogin(): void {
$this->user = (new \Gazelle\UserCreator())
$this->user = (new UserCreator())
->setUsername('phpunit.' . randomString(10))
->setEmail('[email protected]')
->setPassword('password')
->setAdminComment('phpunit test login')
->create();
$login = new Gazelle\Login();
$watch = new Gazelle\LoginWatch($login->requestContext()->remoteAddr());
$login = new Login();
$watch = new LoginWatch($login->requestContext()->remoteAddr());
$watch->clearAttempts();
$result = $login->login($this->user->username(), 'not-the-password!', $watch);
$this->assertNull($result, 'user-create-login-bad-pw-null');
$this->assertEquals(\Gazelle\Login::ERR_CREDENTIALS, $login->error(), 'user-create-login-bad-pw-error');
$this->assertEquals(Login::ERR_CREDENTIALS, $login->error(), 'user-create-login-bad-pw-error');
$result = $login->login($this->user->username(), 'password', $watch);
$this->assertNull($result, 'user-create-login-unconfirmed-null');
$this->assertEquals(\Gazelle\Login::ERR_UNCONFIRMED, $login->error(), 'user-create-login-unconfirmed-error');
$this->assertEquals(Login::ERR_UNCONFIRMED, $login->error(), 'user-create-login-unconfirmed-error');
$this->assertEquals(2, $watch->nrAttempts(), 'user-create-two-login-attempts');
$this->user->setField('Enabled', '2')->modify();
$enabledUser = $login->login($this->user->username(), 'password', $watch);
$this->assertInstanceOf(\Gazelle\User::class, $enabledUser, 'user-create-login-success');
$this->assertInstanceOf(User::class, $enabledUser, 'user-create-login-success');
$this->assertEquals(0, $watch->nrAttempts(), 'user-create-two-login-cleared');
$this->assertEquals(0, $watch->nrBans(), 'user-create-two-login-banned');
}
@@ -75,26 +77,26 @@ class UserCreateTest extends TestCase {
public function testZeroFailure(): void {
$_SERVER['HTTP_USER_AGENT'] = 'phpunit';
$creator = (new \Gazelle\UserCreator())
$creator = (new UserCreator())
->setUsername('0')
->setEmail("[email protected]")
->setPassword(randomString(20))
->setAdminComment('Created by tests/phpunit/UserCreateTest.php');
$this->expectException(Gazelle\Exception\UserCreatorException::class);
$this->expectException(Exception\UserCreatorException::class);
$creator->create();
}
public function testNameFailure(): void {
$_SERVER['HTTP_USER_AGENT'] = 'phpunit';
$creator = (new \Gazelle\UserCreator())
$creator = (new UserCreator())
->setUsername(randomString(21))
->setEmail("[email protected]")
->setPassword(randomString(20))
->setAdminComment('Created by tests/phpunit/UserCreateTest.php');
$this->expectException(Gazelle\Exception\UserCreatorException::class);
$this->expectException(Exception\UserCreatorException::class);
$creator->create();
$this->assertFalse($creator->newInstall(), 'user-creator-not-new-install'); // simply to check the SQL
@@ -102,13 +104,13 @@ class UserCreateTest extends TestCase {
public function testNameTrim(): void {
$_SERVER['HTTP_USER_AGENT'] = 'phpunit';
$this->user = (new \Gazelle\UserCreator())
$this->user = (new UserCreator())
->setUsername(' ' . randomString(6))
->setEmail("[email protected]")
->setPassword(randomString(20))
->setAdminComment('Created by tests/phpunit/UserCreateTest.php')
->create();
$this->assertInstanceOf(Gazelle\User::class, $this->user, 'user-create-trim');
$this->assertInstanceOf(User::class, $this->user, 'user-create-trim');
}
}