From 126e6a3c2f99c8e3ec994d8ce50d008b0f0ec43f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Karol=20S=C3=B3jko?= <karolsojko@protonmail.com>
Date: Thu, 20 Oct 2022 14:02:30 +0200
Subject: [PATCH] fix(auth): additional response message to accepting
 invitation

---
 .../AcceptSharedSubscriptionInvitation.spec.ts                | 4 ++++
 .../AcceptSharedSubscriptionInvitation.ts                     | 4 ++++
 .../AcceptSharedSubscriptionInvitationResponse.ts             | 1 +
 3 files changed, 9 insertions(+)

diff --git a/packages/auth/src/Domain/UseCase/AcceptSharedSubscriptionInvitation/AcceptSharedSubscriptionInvitation.spec.ts b/packages/auth/src/Domain/UseCase/AcceptSharedSubscriptionInvitation/AcceptSharedSubscriptionInvitation.spec.ts
index ed9e13291..7477ed7a4 100644
--- a/packages/auth/src/Domain/UseCase/AcceptSharedSubscriptionInvitation/AcceptSharedSubscriptionInvitation.spec.ts
+++ b/packages/auth/src/Domain/UseCase/AcceptSharedSubscriptionInvitation/AcceptSharedSubscriptionInvitation.spec.ts
@@ -116,6 +116,7 @@ describe('AcceptSharedSubscriptionInvitation', () => {
       }),
     ).toEqual({
       success: false,
+      message: 'Could not find the subscription invitation. It may have been already accepted or declined.',
     })
 
     expect(sharedSubscriptionInvitationRepository.save).not.toHaveBeenCalled()
@@ -132,6 +133,8 @@ describe('AcceptSharedSubscriptionInvitation', () => {
       }),
     ).toEqual({
       success: false,
+      message:
+        'Could not find the invitee in our user database. Please first register an account before accepting the invitation.',
     })
 
     expect(sharedSubscriptionInvitationRepository.save).not.toHaveBeenCalled()
@@ -148,6 +151,7 @@ describe('AcceptSharedSubscriptionInvitation', () => {
       }),
     ).toEqual({
       success: false,
+      message: 'The person that invited you does not have a running subscription with Standard Notes anymore.',
     })
 
     expect(sharedSubscriptionInvitationRepository.save).not.toHaveBeenCalled()
diff --git a/packages/auth/src/Domain/UseCase/AcceptSharedSubscriptionInvitation/AcceptSharedSubscriptionInvitation.ts b/packages/auth/src/Domain/UseCase/AcceptSharedSubscriptionInvitation/AcceptSharedSubscriptionInvitation.ts
index 88f64728b..a86df5629 100644
--- a/packages/auth/src/Domain/UseCase/AcceptSharedSubscriptionInvitation/AcceptSharedSubscriptionInvitation.ts
+++ b/packages/auth/src/Domain/UseCase/AcceptSharedSubscriptionInvitation/AcceptSharedSubscriptionInvitation.ts
@@ -37,6 +37,7 @@ export class AcceptSharedSubscriptionInvitation implements UseCaseInterface {
     if (sharedSubscriptionInvitation === null) {
       return {
         success: false,
+        message: 'Could not find the subscription invitation. It may have been already accepted or declined.',
       }
     }
 
@@ -44,6 +45,8 @@ export class AcceptSharedSubscriptionInvitation implements UseCaseInterface {
     if (invitee === null) {
       return {
         success: false,
+        message:
+          'Could not find the invitee in our user database. Please first register an account before accepting the invitation.',
       }
     }
 
@@ -54,6 +57,7 @@ export class AcceptSharedSubscriptionInvitation implements UseCaseInterface {
     if (inviterUserSubscriptions.length !== 1) {
       return {
         success: false,
+        message: 'The person that invited you does not have a running subscription with Standard Notes anymore.',
       }
     }
     const inviterUserSubscription = inviterUserSubscriptions[0]
diff --git a/packages/auth/src/Domain/UseCase/AcceptSharedSubscriptionInvitation/AcceptSharedSubscriptionInvitationResponse.ts b/packages/auth/src/Domain/UseCase/AcceptSharedSubscriptionInvitation/AcceptSharedSubscriptionInvitationResponse.ts
index c8443c951..194887fe6 100644
--- a/packages/auth/src/Domain/UseCase/AcceptSharedSubscriptionInvitation/AcceptSharedSubscriptionInvitationResponse.ts
+++ b/packages/auth/src/Domain/UseCase/AcceptSharedSubscriptionInvitation/AcceptSharedSubscriptionInvitationResponse.ts
@@ -1,3 +1,4 @@
 export type AcceptSharedSubscriptionInvitationResponse = {
   success: boolean
+  message?: string
 }