mylesmarkevich/standardnotes-server
1
0
Fork 0
mirror of https://github.com/standardnotes/server synced 2026-08-01 08:16:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

feat: sign in setting refactor (#472)

Browse Source 
* fix(auth): refactor setting names into domain core value objects

* fix(auth): refactor specs with setting name value objects

* feat(auth): move mute sign in emails to a subscription kind of setting

* feat(auth): add migration script to change sign in email settings to subscription settings

* chore: fix setting name usage

* fix(auth): upper casing setting names

---------

Co-authored-by: Karol Sójko <[email protected]>
This commit is contained in:
Karol Sójko
2023-03-08 10:22:27 +01:00
committed by GitHub
co-authored by Karol Sójko
parent ec0fb7e0b9
commit 27cf093f85
67 changed files with 1450 additions and 809 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/syncing-server/src/Infra/HTTP/AuthHttpService.spec.ts
+2 -2
View File
@@ -49,7 +49,7 @@ describe('AuthHttpService', () => {
},
})
await createService().getUserSetting('1-2-3', SettingName.MuteFailedBackupsEmails)
await createService().getUserSetting('1-2-3', SettingName.NAMES.MuteFailedBackupsEmails)
expect(httpClient.request).toHaveBeenCalledWith({
method: 'GET',
@@ -64,7 +64,7 @@ describe('AuthHttpService', () => {
it('should throw an error if a request to auth service in order to get user setting fails', async () => {
let error = null
try {
await createService().getUserSetting('1-2-3', SettingName.MuteFailedCloudBackupsEmails)
await createService().getUserSetting('1-2-3', SettingName.NAMES.MuteFailedCloudBackupsEmails)
} catch (caughtError) {
error = caughtError
}