From 3d475cc779f13c7da961a62f8f6abe69f76609fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Karol=20S=C3=B3jko?= Date: Tue, 24 Jan 2023 08:24:20 +0100 Subject: [PATCH] fix(auth): fido options user verification as discouraged --- .../GenerateAuthenticatorAuthenticationOptions.ts | 2 +- .../GenerateAuthenticatorRegistrationOptions.ts | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/auth/src/Domain/UseCase/GenerateAuthenticatorAuthenticationOptions/GenerateAuthenticatorAuthenticationOptions.ts b/packages/auth/src/Domain/UseCase/GenerateAuthenticatorAuthenticationOptions/GenerateAuthenticatorAuthenticationOptions.ts index 699608d18..43009f2e8 100644 --- a/packages/auth/src/Domain/UseCase/GenerateAuthenticatorAuthenticationOptions/GenerateAuthenticatorAuthenticationOptions.ts +++ b/packages/auth/src/Domain/UseCase/GenerateAuthenticatorAuthenticationOptions/GenerateAuthenticatorAuthenticationOptions.ts @@ -26,7 +26,7 @@ export class GenerateAuthenticatorAuthenticationOptions implements UseCaseInterf type: 'public-key', transports: authenticator.props.transports, })), - userVerification: 'preferred', + userVerification: 'discouraged', }) const authenticatorChallengeOrError = AuthenticatorChallenge.create({ diff --git a/packages/auth/src/Domain/UseCase/GenerateAuthenticatorRegistrationOptions/GenerateAuthenticatorRegistrationOptions.ts b/packages/auth/src/Domain/UseCase/GenerateAuthenticatorRegistrationOptions/GenerateAuthenticatorRegistrationOptions.ts index 12aea2ca2..85afa4ed4 100644 --- a/packages/auth/src/Domain/UseCase/GenerateAuthenticatorRegistrationOptions/GenerateAuthenticatorRegistrationOptions.ts +++ b/packages/auth/src/Domain/UseCase/GenerateAuthenticatorRegistrationOptions/GenerateAuthenticatorRegistrationOptions.ts @@ -34,6 +34,10 @@ export class GenerateAuthenticatorRegistrationOptions implements UseCaseInterfac userID: userUuid.value, userName: username.value, attestationType: 'none', + authenticatorSelection: { + requireResidentKey: false, + userVerification: 'discouraged', + }, excludeCredentials: authenticators.map((authenticator) => ({ id: authenticator.props.credentialId, type: 'public-key',