feat(revisions): add persisting revisions from s3 dump

packages/syncing-server/src/Domain/Handler/ItemRevisionCreationRequestedEventHandler.spec.ts

@@ -5,16 +5,15 @@ import {
   DomainEventService,
   ItemRevisionCreationRequestedEvent,
 } from '@standardnotes/domain-events'
+
 import { Item } from '../Item/Item'
 import { ItemRepositoryInterface } from '../Item/ItemRepositoryInterface'
 import { ItemRevisionCreationRequestedEventHandler } from './ItemRevisionCreationRequestedEventHandler'
-import { RevisionServiceInterface } from '../Revision/RevisionServiceInterface'
 import { ItemBackupServiceInterface } from '../Item/ItemBackupServiceInterface'
 import { DomainEventFactoryInterface } from '../Event/DomainEventFactoryInterface'
 
 describe('ItemRevisionCreationRequestedEventHandler', () => {
   let itemRepository: ItemRepositoryInterface
-  let revisionService: RevisionServiceInterface
   let event: ItemRevisionCreationRequestedEvent
   let item: Item
   let itemBackupService: ItemBackupServiceInterface
@@ -24,7 +23,6 @@ describe('ItemRevisionCreationRequestedEventHandler', () => {
   const createHandler = () =>
     new ItemRevisionCreationRequestedEventHandler(
       itemRepository,
-      revisionService,
       itemBackupService,
       domainEventFactory,
       domainEventPublisher,
@@ -39,9 +37,6 @@ describe('ItemRevisionCreationRequestedEventHandler', () => {
     itemRepository = {} as jest.Mocked<ItemRepositoryInterface>
     itemRepository.findByUuid = jest.fn().mockReturnValue(item)
 
-    revisionService = {} as jest.Mocked<RevisionServiceInterface>
-    revisionService.createRevision = jest.fn()
-
     event = {} as jest.Mocked<ItemRevisionCreationRequestedEvent>
     event.createdAt = new Date(1)
     event.payload = {
@@ -68,7 +63,6 @@ describe('ItemRevisionCreationRequestedEventHandler', () => {
   it('should create a revision for an item', async () => {
     await createHandler().handle(event)
 
-    expect(revisionService.createRevision).toHaveBeenCalled()
     expect(domainEventPublisher.publish).toHaveBeenCalled()
     expect(domainEventFactory.createItemDumpedEvent).toHaveBeenCalled()
   })
@@ -78,7 +72,7 @@ describe('ItemRevisionCreationRequestedEventHandler', () => {
 
     await createHandler().handle(event)
 
-    expect(revisionService.createRevision).not.toHaveBeenCalled()
+    expect(domainEventPublisher.publish).not.toHaveBeenCalled()
   })
 
   it('should not create a revision for an item if the dump was not created', async () => {

packages/syncing-server/src/Domain/Handler/ItemRevisionCreationRequestedEventHandler.ts

@@ -9,13 +9,11 @@ import TYPES from '../../Bootstrap/Types'
 import { DomainEventFactoryInterface } from '../Event/DomainEventFactoryInterface'
 import { ItemBackupServiceInterface } from '../Item/ItemBackupServiceInterface'
 import { ItemRepositoryInterface } from '../Item/ItemRepositoryInterface'
-import { RevisionServiceInterface } from '../Revision/RevisionServiceInterface'
 
 @injectable()
 export class ItemRevisionCreationRequestedEventHandler implements DomainEventHandlerInterface {
   constructor(
     @inject(TYPES.ItemRepository) private itemRepository: ItemRepositoryInterface,
-    @inject(TYPES.RevisionService) private revisionService: RevisionServiceInterface,
     @inject(TYPES.ItemBackupService) private itemBackupService: ItemBackupServiceInterface,
     @inject(TYPES.DomainEventFactory) private domainEventFactory: DomainEventFactoryInterface,
     @inject(TYPES.DomainEventPublisher) private domainEventPublisher: DomainEventPublisherInterface,
@@ -33,7 +31,5 @@ export class ItemRevisionCreationRequestedEventHandler implements DomainEventHan
         this.domainEventFactory.createItemDumpedEvent(fileDumpPath, event.meta.correlation.userIdentifier),
       )
     }
-
-    await this.revisionService.createRevision(item)
   }
 }