mylesmarkevich/standardnotes-server
1
0
Fork 0
mirror of https://github.com/standardnotes/server synced 2026-10-19 09:03:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

Revert "fix(auth): disallow adding u2f devices if a user does not have 2fa enabled"

Browse Source 
This reverts commit 11bcd318ab.
This commit is contained in:
Karol Sójko
2023-02-02 14:50:41 +01:00
parent 6e26c0a0be
commit bf55bbccd9
5 changed files with 0 additions and 130 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/auth/src/Domain/UseCase/VerifyAuthenticatorRegistrationResponse/VerifyAuthenticatorRegistrationResponse.spec.ts
-61
View File
@@ -6,20 +6,16 @@ import { Authenticator } from '../../Authenticator/Authenticator'
import { AuthenticatorChallenge } from '../../Authenticator/AuthenticatorChallenge'
import { AuthenticatorChallengeRepositoryInterface } from '../../Authenticator/AuthenticatorChallengeRepositoryInterface'
import { AuthenticatorRepositoryInterface } from '../../Authenticator/AuthenticatorRepositoryInterface'
import { Setting } from '../../Setting/Setting'
import { SettingServiceInterface } from '../../Setting/SettingServiceInterface'
import { VerifyAuthenticatorRegistrationResponse } from './VerifyAuthenticatorRegistrationResponse'
describe('VerifyAuthenticatorRegistrationResponse', () => {
let authenticatorRepository: AuthenticatorRepositoryInterface
let authenticatorChallengeRepository: AuthenticatorChallengeRepositoryInterface
let settingService: SettingServiceInterface
const createUseCase = () =>
new VerifyAuthenticatorRegistrationResponse(
authenticatorRepository,
authenticatorChallengeRepository,
settingService,
'standardnotes.com',
['localhost', 'https://app.standardnotes.com'],
true,
@@ -35,11 +31,6 @@ describe('VerifyAuthenticatorRegistrationResponse', () => {
challenge: Buffer.from('challenge'),
},
} as jest.Mocked<AuthenticatorChallenge>)
settingService = {} as jest.Mocked<SettingServiceInterface>
settingService.findSettingWithDecryptedValue = jest.fn().mockReturnValue({
value: 'secret',
} as jest.Mocked<Setting>)
})
it('should return error if user uuid is invalid', async () => {
@@ -65,58 +56,6 @@ describe('VerifyAuthenticatorRegistrationResponse', () => {
)
})
it('should return error if user does not have 2FA enabled', async () => {
settingService.findSettingWithDecryptedValue = jest.fn().mockReturnValue(null)
const useCase = createUseCase()
const result = await useCase.execute({
userUuid: '00000000-0000-0000-0000-000000000000',
name: 'name',
attestationResponse: {
id: Buffer.from('id'),
rawId: Buffer.from('rawId'),
response: {
attestationObject: Buffer.from('attestationObject'),
clientDataJSON: Buffer.from('clientDataJSON'),
},
type: 'type',
},
})
expect(result.isFailed()).toBeTruthy()
expect(result.getError()).toEqual(
'Could not verify authenticator registration response: Fallback 2FA not enabled for user.',
)
})
it('should return error if user has 2FA disabled', async () => {
settingService.findSettingWithDecryptedValue = jest.fn().mockReturnValue({
value: null,
} as jest.Mocked<Setting>)
const useCase = createUseCase()
const result = await useCase.execute({
userUuid: '00000000-0000-0000-0000-000000000000',
name: 'name',
attestationResponse: {
id: Buffer.from('id'),
rawId: Buffer.from('rawId'),
response: {
attestationObject: Buffer.from('attestationObject'),
clientDataJSON: Buffer.from('clientDataJSON'),
},
type: 'type',
},
})
expect(result.isFailed()).toBeTruthy()
expect(result.getError()).toEqual(
'Could not verify authenticator registration response: Fallback 2FA not enabled for user.',
)
})
it('should return error if name is invalid', async () => {
const useCase = createUseCase()
packages/auth/src/Domain/UseCase/VerifyAuthenticatorRegistrationResponse/VerifyAuthenticatorRegistrationResponse.ts
-12
View File
@@ -5,14 +5,11 @@ import { AuthenticatorChallengeRepositoryInterface } from '../../Authenticator/A
import { AuthenticatorRepositoryInterface } from '../../Authenticator/AuthenticatorRepositoryInterface'
import { Authenticator } from '../../Authenticator/Authenticator'
import { VerifyAuthenticatorRegistrationResponseDTO } from './VerifyAuthenticatorRegistrationResponseDTO'
import { SettingName } from '@standardnotes/settings'
import { SettingServiceInterface } from '../../Setting/SettingServiceInterface'
export class VerifyAuthenticatorRegistrationResponse implements UseCaseInterface<boolean> {
constructor(
private authenticatorRepository: AuthenticatorRepositoryInterface,
private authenticatorChallengeRepository: AuthenticatorChallengeRepositoryInterface,
private settingService: SettingServiceInterface,
private relyingPartyId: string,
private expectedOrigin: string[],
private requireUserVerification: boolean,
@@ -25,15 +22,6 @@ export class VerifyAuthenticatorRegistrationResponse implements UseCaseInterface
}
const userUuid = userUuidOrError.getValue()
const mfaSecret = await this.settingService.findSettingWithDecryptedValue({
userUuid: userUuid.value,
settingName: SettingName.MfaSecret,
})
const twoFactorEnabled = mfaSecret !== null && mfaSecret.value !== null
if (!twoFactorEnabled) {
return Result.fail('Could not verify authenticator registration response: Fallback 2FA not enabled for user.')
}
const nameValidation = Validator.isNotEmpty(dto.name)
if (nameValidation.isFailed()) {
return Result.fail(`Could not verify authenticator registration response: ${nameValidation.getError()}`)