From d4830dec018139ffaf93d0e91d6655c5dcc6be9c Mon Sep 17 00:00:00 2001
From: Aman Harwara <amanharwara@protonmail.com>
Date: Thu, 7 Sep 2023 11:37:06 +0530
Subject: [PATCH] feat: add VaultsUser role name (#809)

* feat: add VaultsUser role name

* fix: test coverage
---
 packages/domain-core/src/Domain/Common/RoleName.ts |  2 ++
 .../src/Domain/Common/RoleNameCollection.spec.ts   | 14 +++++++++++++-
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/packages/domain-core/src/Domain/Common/RoleName.ts b/packages/domain-core/src/Domain/Common/RoleName.ts
index 894a03d33..5334f06d6 100644
--- a/packages/domain-core/src/Domain/Common/RoleName.ts
+++ b/packages/domain-core/src/Domain/Common/RoleName.ts
@@ -9,6 +9,7 @@ export class RoleName extends ValueObject<RoleNameProps> {
     ProUser: 'PRO_USER',
     InternalTeamUser: 'INTERNAL_TEAM_USER',
     TransitionUser: 'TRANSITION_USER',
+    VaultsUser: 'VAULTS_USER',
   }
 
   get value(): string {
@@ -32,6 +33,7 @@ export class RoleName extends ValueObject<RoleNameProps> {
         )
       case RoleName.NAMES.CoreUser:
       case RoleName.NAMES.TransitionUser:
+      case RoleName.NAMES.VaultsUser:
         return [RoleName.NAMES.CoreUser, RoleName.NAMES.TransitionUser].includes(roleName.value)
       /*istanbul ignore next*/
       default:
diff --git a/packages/domain-core/src/Domain/Common/RoleNameCollection.spec.ts b/packages/domain-core/src/Domain/Common/RoleNameCollection.spec.ts
index 2e6679695..4eb92fd87 100644
--- a/packages/domain-core/src/Domain/Common/RoleNameCollection.spec.ts
+++ b/packages/domain-core/src/Domain/Common/RoleNameCollection.spec.ts
@@ -51,7 +51,7 @@ describe('RoleNameCollection', () => {
   })
 
   it('should tell if collection has a role with more or equal power to', () => {
-    let roles = [RoleName.NAMES.CoreUser]
+    let roles = [RoleName.NAMES.VaultsUser]
     let valueOrError = RoleNameCollection.create(roles)
     let roleNames = valueOrError.getValue()
 
@@ -63,6 +63,18 @@ describe('RoleNameCollection', () => {
       roleNames.hasARoleNameWithMoreOrEqualPowerTo(RoleName.create(RoleName.NAMES.CoreUser).getValue()),
     ).toBeTruthy()
 
+    roles = [RoleName.NAMES.CoreUser]
+    valueOrError = RoleNameCollection.create(roles)
+    roleNames = valueOrError.getValue()
+
+    expect(
+      roleNames.hasARoleNameWithMoreOrEqualPowerTo(RoleName.create(RoleName.NAMES.PlusUser).getValue()),
+    ).toBeFalsy()
+    expect(roleNames.hasARoleNameWithMoreOrEqualPowerTo(RoleName.create(RoleName.NAMES.ProUser).getValue())).toBeFalsy()
+    expect(
+      roleNames.hasARoleNameWithMoreOrEqualPowerTo(RoleName.create(RoleName.NAMES.CoreUser).getValue()),
+    ).toBeTruthy()
+
     roles = [RoleName.NAMES.CoreUser, RoleName.NAMES.PlusUser]
     valueOrError = RoleNameCollection.create(roles)
     roleNames = valueOrError.getValue()