From e2aae8ac8a98dff9f618709c33f7b80479747ec9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Karol=20S=C3=B3jko?= <karolsojko@protonmail.com>
Date: Tue, 17 Jan 2023 11:00:05 +0100
Subject: [PATCH] fix(revisions): response structure

---
 packages/revisions/src/Controller/RevisionsController.ts  | 8 +++++---
 .../InversifyExpressRevisionsController.ts                | 4 ++--
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/packages/revisions/src/Controller/RevisionsController.ts b/packages/revisions/src/Controller/RevisionsController.ts
index 8da51f226..a027847f7 100644
--- a/packages/revisions/src/Controller/RevisionsController.ts
+++ b/packages/revisions/src/Controller/RevisionsController.ts
@@ -63,12 +63,14 @@ export class RevisionsController {
       }
     }
 
+    const revisions = revisionMetadataOrError.getValue()
+
+    this.logger.debug(`Found ${revisions.length} revisions for item ${params.itemUuid}`)
+
     return {
       status: HttpStatusCode.Success,
       data: {
-        revisions: revisionMetadataOrError
-          .getValue()
-          .map((revision) => this.revisionMetadataHttpMapper.toProjection(revision)),
+        revisions: revisions.map((revision) => this.revisionMetadataHttpMapper.toProjection(revision)),
       },
     }
   }
diff --git a/packages/revisions/src/Infra/InversifyExpress/InversifyExpressRevisionsController.ts b/packages/revisions/src/Infra/InversifyExpress/InversifyExpressRevisionsController.ts
index 693c2cd17..52091a16e 100644
--- a/packages/revisions/src/Infra/InversifyExpress/InversifyExpressRevisionsController.ts
+++ b/packages/revisions/src/Infra/InversifyExpress/InversifyExpressRevisionsController.ts
@@ -18,7 +18,7 @@ export class InversifyExpressRevisionsController extends BaseHttpController {
       userUuid: response.locals.user.uuid,
     })
 
-    return this.json(result.data.error ? result.data : result.data.revisions, result.status)
+    return this.json(result.data, result.status)
   }
 
   @httpGet('/:uuid')
@@ -28,7 +28,7 @@ export class InversifyExpressRevisionsController extends BaseHttpController {
       userUuid: response.locals.user.uuid,
     })
 
-    return this.json(result.data.error ? result.data : result.data.revision, result.status)
+    return this.json(result.data, result.status)
   }
 
   @httpDelete('/:uuid')