From fc5cea11b5401f83a0f8cf2b386abbff90bd18d7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Karol=20S=C3=B3jko?= <karolsojko@protonmail.com>
Date: Mon, 11 Jul 2022 12:55:17 +0200
Subject: [PATCH] fix: log errors on not being able to create a backup file

---
 .../EmailBackupRequestedEventHandler.spec.ts  |  1 +
 .../EmailBackupRequestedEventHandler.ts       | 24 +++++++++++--------
 2 files changed, 15 insertions(+), 10 deletions(-)

diff --git a/packages/syncing-server/src/Domain/Handler/EmailBackupRequestedEventHandler.spec.ts b/packages/syncing-server/src/Domain/Handler/EmailBackupRequestedEventHandler.spec.ts
index a13e223a1..3fe9829d0 100644
--- a/packages/syncing-server/src/Domain/Handler/EmailBackupRequestedEventHandler.spec.ts
+++ b/packages/syncing-server/src/Domain/Handler/EmailBackupRequestedEventHandler.spec.ts
@@ -72,6 +72,7 @@ describe('EmailBackupRequestedEventHandler', () => {
     logger = {} as jest.Mocked<Logger>
     logger.debug = jest.fn()
     logger.warn = jest.fn()
+    logger.error = jest.fn()
   })
 
   it('should inform that backup attachment for email was created', async () => {
diff --git a/packages/syncing-server/src/Domain/Handler/EmailBackupRequestedEventHandler.ts b/packages/syncing-server/src/Domain/Handler/EmailBackupRequestedEventHandler.ts
index 4f18afd89..9c9a1f39c 100644
--- a/packages/syncing-server/src/Domain/Handler/EmailBackupRequestedEventHandler.ts
+++ b/packages/syncing-server/src/Domain/Handler/EmailBackupRequestedEventHandler.ts
@@ -63,18 +63,22 @@ export class EmailBackupRequestedEventHandler implements DomainEventHandlerInter
 
       this.logger.debug(`Data backed up into: ${backupFileName}`)
 
-      if (backupFileName.length !== 0) {
-        this.logger.debug('Publishing EMAIL_BACKUP_ATTACHMENT_CREATED event')
+      if (backupFileName.length === 0) {
+        this.logger.error(`Could not create a backup file for user ${event.payload.userUuid}`)
 
-        await this.domainEventPublisher.publish(
-          this.domainEventFactory.createEmailBackupAttachmentCreatedEvent({
-            backupFileName,
-            backupFileIndex: bundleIndex++,
-            backupFilesTotal: itemUuidBundles.length,
-            email: authParams.identifier as string,
-          }),
-        )
+        return
       }
+
+      this.logger.debug('Publishing EMAIL_BACKUP_ATTACHMENT_CREATED event')
+
+      await this.domainEventPublisher.publish(
+        this.domainEventFactory.createEmailBackupAttachmentCreatedEvent({
+          backupFileName,
+          backupFileIndex: bundleIndex++,
+          backupFilesTotal: itemUuidBundles.length,
+          email: authParams.identifier as string,
+        }),
+      )
     }
   }
 }