From 94e4893b89a2ab63257bdc596783295c85f9cdff Mon Sep 17 00:00:00 2001 From: Undercova Date: Sun, 4 Feb 2024 15:10:38 +0100 Subject: [PATCH 1/2] Updated the Test for LS to match the updated crystal values --- .../global/commands/callbacks/LightsaberInventoryTest.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/com/projectswg/holocore/resources/support/global/commands/callbacks/LightsaberInventoryTest.kt b/src/test/java/com/projectswg/holocore/resources/support/global/commands/callbacks/LightsaberInventoryTest.kt index c1e0e3758..58ee32d52 100644 --- a/src/test/java/com/projectswg/holocore/resources/support/global/commands/callbacks/LightsaberInventoryTest.kt +++ b/src/test/java/com/projectswg/holocore/resources/support/global/commands/callbacks/LightsaberInventoryTest.kt @@ -74,7 +74,7 @@ class LightsaberInventoryTest : TestRunnerSimulatedWorld() { transferItem(player, colorCrystal, lightsaber.lightsaberInventory) - assertEquals(14, lightsaber.elementalValue) // The color crystal takes 6% of lightsaber max damage and turns that into the elemental value, rounded down + assertEquals(12, lightsaber.elementalValue) // The color crystal takes 4% of lightsaber max damage and turns that into the elemental value, rounded down } @Test From c9434104ecfec745a687871ef702dc46bfe191c9 Mon Sep 17 00:00:00 2001 From: Undercova Date: Sun, 17 Mar 2024 22:03:47 +0100 Subject: [PATCH 2/2] Fixed the lightsaber inventory test since values for all lightsabers were set like on live server --- .../global/commands/callbacks/LightsaberInventoryTest.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/java/com/projectswg/holocore/resources/support/global/commands/callbacks/LightsaberInventoryTest.kt b/src/test/java/com/projectswg/holocore/resources/support/global/commands/callbacks/LightsaberInventoryTest.kt index 58ee32d52..d78edeeb4 100644 --- a/src/test/java/com/projectswg/holocore/resources/support/global/commands/callbacks/LightsaberInventoryTest.kt +++ b/src/test/java/com/projectswg/holocore/resources/support/global/commands/callbacks/LightsaberInventoryTest.kt @@ -74,7 +74,7 @@ class LightsaberInventoryTest : TestRunnerSimulatedWorld() { transferItem(player, colorCrystal, lightsaber.lightsaberInventory) - assertEquals(12, lightsaber.elementalValue) // The color crystal takes 4% of lightsaber max damage and turns that into the elemental value, rounded down + assertEquals(14, lightsaber.elementalValue) // The color crystal takes 6% of lightsaber max damage and turns that into the elemental value, rounded down } @Test @@ -352,7 +352,7 @@ class LightsaberInventoryTest : TestRunnerSimulatedWorld() { } private fun createColorCrystal(): TangibleObject { - val colorCrystal = StaticItemCreator.createItem("item_color_crystal_02_29") as TangibleObject? + val colorCrystal = StaticItemCreator.createItem("item_color_crystal_02_20") as TangibleObject? colorCrystal ?: throw RuntimeException("Unable to create color crystal") broadcastAndWait(ObjectCreatedIntent(colorCrystal))