From 1178706728702aac62bf2d95b0e0d729b3717e40 Mon Sep 17 00:00:00 2001
From: Ziggy <ziggyswg@outlook.com>
Date: Fri, 30 Dec 2022 02:18:39 +0100
Subject: [PATCH] Wrote regression test for a bug with Healing Efficiency,
 where it could decrease the amount of damage healed instead of increasing it

---
 .../combat/command/CombatCommandHealTest.kt   | 96 +++++++++++++++++++
 1 file changed, 96 insertions(+)
 create mode 100644 src/test/java/com/projectswg/holocore/services/gameplay/combat/command/CombatCommandHealTest.kt

diff --git a/src/test/java/com/projectswg/holocore/services/gameplay/combat/command/CombatCommandHealTest.kt b/src/test/java/com/projectswg/holocore/services/gameplay/combat/command/CombatCommandHealTest.kt
new file mode 100644
index 000000000..d879d628d
--- /dev/null
+++ b/src/test/java/com/projectswg/holocore/services/gameplay/combat/command/CombatCommandHealTest.kt
@@ -0,0 +1,96 @@
+package com.projectswg.holocore.services.gameplay.combat.command
+
+import com.projectswg.common.data.CRC
+import com.projectswg.common.network.packets.swg.login.creation.ClientCreateCharacter
+import com.projectswg.common.network.packets.swg.zone.object_controller.CommandQueueEnqueue
+import com.projectswg.common.network.packets.swg.zone.object_controller.CommandTimer
+import com.projectswg.holocore.intents.gameplay.player.experience.skills.GrantSkillIntent
+import com.projectswg.holocore.intents.support.global.network.InboundPacketIntent
+import com.projectswg.holocore.resources.support.data.server_info.loader.DataLoader
+import com.projectswg.holocore.resources.support.data.server_info.loader.ServerData
+import com.projectswg.holocore.resources.support.global.player.AccessLevel
+import com.projectswg.holocore.resources.support.global.player.Player
+import com.projectswg.holocore.resources.support.global.zone.creation.CharacterCreation
+import com.projectswg.holocore.resources.support.objects.swg.creature.CreatureObject
+import com.projectswg.holocore.services.gameplay.combat.CombatStatusService
+import com.projectswg.holocore.services.gameplay.combat.buffs.BuffService
+import com.projectswg.holocore.services.gameplay.player.experience.skills.SkillService
+import com.projectswg.holocore.services.gameplay.player.experience.skills.skillmod.SkillModService
+import com.projectswg.holocore.services.support.global.commands.CommandExecutionService
+import com.projectswg.holocore.services.support.global.commands.CommandQueueService
+import com.projectswg.holocore.test.resources.GenericPlayer
+import com.projectswg.holocore.test.runners.TestRunnerSimulatedWorld
+import org.junit.jupiter.api.Assertions.assertTrue
+import org.junit.jupiter.api.BeforeEach
+import org.junit.jupiter.api.Test
+
+class CombatCommandHealTest : TestRunnerSimulatedWorld() {
+
+    @BeforeEach
+    fun setup() {
+        registerService(BuffService())
+        registerService(CommandQueueService(5))
+        registerService(CommandExecutionService())
+        registerService(CombatStatusService())
+        registerService(SkillService())
+        registerService(SkillModService())
+    }
+
+    @Test
+    fun `healing restores health`() {
+        val startingHealth = 100
+        val creatureObject = createCreatureObject(startingHealth)
+        val player = creatureObject.owner ?: throw RuntimeException("Unable to access player")
+        broadcastAndWait(GrantSkillIntent(GrantSkillIntent.IntentType.GRANT, "science_medic_novice", creatureObject, true))
+        
+        bactaShot(player)
+
+        val resultingHealth = creatureObject.health
+        assertTrue(resultingHealth > startingHealth)
+    }
+
+    @Test
+    fun `Healing Efficiency skill modifier increases damage healed`() {
+        val startingHealth = 100
+        val creatureObject = createCreatureObject(startingHealth)
+        val player = creatureObject.owner ?: throw RuntimeException("Unable to access player")
+        broadcastAndWait(GrantSkillIntent(GrantSkillIntent.IntentType.GRANT, "science_medic_novice", creatureObject, true))
+        
+        bactaShot(player)
+
+        val healed = creatureObject.health - startingHealth
+        val bactaShotAddedDamage = getBactaShotAddedDamage()
+        assertTrue(healed > bactaShotAddedDamage)
+    }
+
+    private fun getBactaShotAddedDamage(): Int {
+        val combatCommand = ServerData.combatCommands.getCombatCommand("bactaShot", emptyList())
+                ?: throw RuntimeException("Unable to find combat command")
+        
+        return combatCommand.addedDamage
+    }
+
+    private fun bactaShot(player: Player) {
+        val crc = CRC.getCrc("bactashot")
+
+        broadcastAndWait(InboundPacketIntent(player, CommandQueueEnqueue(player.creatureObject.objectId, 0, crc, 0, "")))
+        (player as GenericPlayer).waitForNextPacket(CommandTimer::class.java)
+    }
+
+    private fun createCreatureObject(currentHealth: Int): CreatureObject {
+        val player = GenericPlayer()
+        val clientCreateCharacter = ClientCreateCharacter()
+        clientCreateCharacter.biography = ""
+        clientCreateCharacter.clothes = "combat_brawler"
+        clientCreateCharacter.race = "object/creature/player/shared_human_male.iff"
+        clientCreateCharacter.name = "Testing Character"
+        val characterCreation = CharacterCreation(player, clientCreateCharacter)
+
+        val mosEisley = DataLoader.zoneInsertions().getInsertion("tat_moseisley")
+        val creatureObject = characterCreation.createCharacter(AccessLevel.PLAYER, mosEisley)
+        creatureObject.owner = player
+        creatureObject.health = currentHealth
+
+        return creatureObject
+    }
+}
\ No newline at end of file