Ziggy
72d90e14eb
Attempt at fixing flakiness of tests in AbilityTest
2022-07-20 21:06:26 +02:00
Ziggy
b60780cfe9
Our other commands are lowercased, so let's lowercase this one as well
2022-07-20 20:52:00 +02:00
Ziggy
f6068438eb
Holocore-671 Previous learned and dropped ability can still be executed from toolbar
...
Reduced test runtime by checking the command queue more often during certain tests
2022-07-20 20:52:00 +02:00
Josh Larson
c9fe97be1c
Added waitForNextPacket function to GenericPlayer for concurrent packet tests
2022-07-20 13:50:16 -05:00
Josh Larson
7b0c2a0506
Merge pull request #686 from madsboddum/Holocore-683
...
Holocore-683 Indoor trainers now show up correctly on planetary map (…
2022-07-20 10:52:20 -05:00
Ziggy
48dab66e95
Holocore-683 Indoor trainers now show up correctly on planetary map (category)
2022-07-20 17:50:41 +02:00
Josh Larson
1b1ee2e701
Merge pull request #687 from madsboddum/Holocore-679
...
Grant Novice Entertainer upon character creation
2022-07-20 10:47:17 -05:00
Ziggy
abac1c4183
Grant Novice Entertainer upon character creation
...
Relates to GitHub issue #679
2022-07-20 17:35:08 +02:00
Ziggy
e81c284253
Fixed utility sourceset compilation error
2022-07-20 17:03:09 +02:00
Josh Larson
07b721d298
Fixed NPCs location in buildings (should not use terrain height)
2022-07-19 17:06:54 -05:00
Josh Larson
b5f597e767
Cleaned up DynamicSpawnService's terrain getHeight call
2022-07-19 06:52:17 -05:00
Josh Larson
6a98b67b77
Cleaned up previous commit in NavigationPoint and set all NPC spawns to the correct elevation
2022-07-18 22:51:48 -05:00
Josh Larson
d2e3e911de
Improved API for accessing the terrain height
2022-07-18 22:23:25 -05:00
Josh Larson
c008ad910d
Fixed dynamic spawn system using new terrain loader
2022-07-18 20:56:13 -05:00
Undercova
c22db42f4c
Added several patrol routes to some Mos Eisley NPCs
...
Renamed the testing rings for combat and crafting
Changed the cloning sound
2022-07-18 22:43:08 +02:00
Josh Larson
20e127e7dc
Merge pull request #673 from madsboddum/Holocore-598
...
Holocore-598 Special attacks should say "Too tired" when their costs …
2022-07-17 13:08:42 -05:00
Ziggy
dd9629741c
Holocore-598 Special attacks should say "Too tired" when their costs exceed your current action or mind
2022-07-17 19:11:32 +02:00
Ziggy
93f8bfe985
Holocore-436 [Brawler] Bleed Attack
2022-07-17 15:53:17 +02:00
Ziggy
a3ce2019ac
Holocore-568 Global cooldown should prevent ability execution
...
More specifically, it should be queued for later execution for when the relevant cooldowns have expired.
2022-07-17 03:21:04 +02:00
Josh Larson
61a2a26d2c
Merge pull request #667 from madsboddum/Improved-tests
...
Improved-tests
2022-07-16 18:43:07 -05:00
Ziggy
a33c613c9a
Improved tests for item transfers by decoupling them from the implementation
...
This way we also get slightly more code coverage, because we're closer to executing a transferItemXXX
command like the real game would.
2022-07-17 01:30:01 +02:00
Ziggy
f6155b8dd2
Better nullability support in Encodable
2022-07-15 20:28:05 +02:00
Josh Larson
e7624de7ba
Merge pull request #629 from madsboddum/group_inviter_name
...
Show name of the player that invited you to a group instead of %TT
2022-07-15 12:00:44 -05:00
Ziggy
d1d6313c3b
Split the single GroupEventIntent into multiple intents, so we can benefit from null-checking by the compiler
2022-07-15 18:57:09 +02:00
Ziggy
065338adb7
Added support for lightsabers, as well as a couple of Lightsaber skill tree abilities
2022-07-15 02:47:58 +02:00
Josh Larson
1086426a30
Merge pull request #662 from madsboddum/skillpoint_cap_249_bug
...
Fixed skillpoint cap being 249 instead of 250
2022-07-13 19:39:16 -05:00
Ziggy
3a532eac9c
Fixed skillpoint cap being 249 instead of 250
2022-07-14 02:36:21 +02:00
Ziggy
f04c17bf7f
Holocore-660 Default attack
2022-07-14 01:51:06 +02:00
Ziggy
4d2d91b56e
Remove unused code for old config files
2022-07-14 00:47:47 +02:00
Josh Larson
774a5e50a2
Merge pull request #657 from madsboddum/Holocore-601
...
Holocore-601 Cloner window shows no city names
2022-07-13 09:49:43 -05:00
Ziggy
f9c9d90001
Holocore-601 Cloner window shows no city names
...
I wasn't able to find the client string, so I just wrote something myself that's pretty close. The city name isn't in the prompt, because we need the prose string for that to work.
2022-07-13 16:26:44 +02:00
Ziggy
9738f35448
Rewrote ActiveQuestRequirementTest so it doesn't need Mockito, as the code is perfectly testable without it
2022-07-13 14:25:49 +02:00
Ziggy
52ea9667f0
Holocore-435 [Brawler] Parry Riposte Stance
...
Lots of file edits because I also created SWGColor and used in relevant places.
It contains commonly used colors for flytexts, so we don't need to look them up each time.
There are way more colors than the ones I added, but I figure it makes sense to add them as we go along.
2022-07-13 02:49:24 +02:00
Josh Larson
90fac06fa6
Merge pull request #654 from madsboddum/unused_highest_id
...
Removed an unused local variable, highestId, that was updated but nev…
2022-07-12 16:11:53 -05:00
Ziggy
a3f38ad5c0
JUnit 4 -> JUnit 5
...
We're still getting JUnit 4 in through fast-json, jlcommon-network and jlcommon.
The solution for them is probably to change "implementation" to "testImplementation".
2022-07-12 15:38:04 +02:00
Ziggy
8538c01522
Removed an unused local variable, highestId, that was updated but never accessed, as a different solution further down figures out what the highest ID is
2022-07-12 13:33:17 +02:00
Josh Larson
3d8276b850
Merge pull request #651 from madsboddum/Holocore-650
...
Holocore-650 Failed command execution should fail instead of triggeri…
2022-07-11 14:56:08 -05:00
Ziggy
002f5a158c
Holocore-650 Failed command execution should fail instead of triggering cooldown
...
I had to make CombatCommandService run as a part of CommandQueueService, so we have a chance to make commands fail properly based on combatcommand-specific checks.
2022-07-11 21:49:13 +02:00
Josh Larson
9fa6ce2e89
Merge pull request #649 from madsboddum/Holocore-428
...
Holocore-428 [Brawler] Taunt
2022-07-11 13:49:53 -05:00
Ziggy
920eb1419a
Holocore-428 [Brawler] Taunt
2022-07-11 16:51:59 +02:00
Ziggy
69c46ebf2f
Holocore-555 Remove buffs for players and vehicles in code
2022-07-11 12:56:33 +02:00
Josh Larson
9ba33afd27
Merge pull request #646 from madsboddum/weao03_range
...
Fixed weapon range not being sent properly to the client
2022-07-10 21:20:17 -05:00
Ziggy
be7a3a1b0c
Added +10 Accuracy to the default weapon as observed in packet captures and reduced attack speed a bit, as it was a pre-CU value
...
Attack speed is a guess - unfortunately this isn't in the WEAO03 packet like it is post NGE.
2022-07-11 04:15:13 +02:00
Ziggy
7f5a4985b8
Fixed weapon range not being sent properly to the client
...
We had attackSpeed in the top of WEAO03, but attackSpeed isn't in there at all post-CU. This caused all variables to be off-by-one.
2022-07-11 04:09:24 +02:00
Ziggy
80df4eae9d
Added some tests that ensure armor certifications are respected
2022-07-11 03:12:02 +02:00
Ziggy
2ef693e548
Added a couple of tests for factional PvP
...
Also created a DefaultWeaponFactory, because the code for creating the default weapon has been copy-pasted a couple of times at this point.
The factory is now used to reduce duplication.
2022-07-11 01:32:30 +02:00
Josh Larson
f70c9d8fb7
Merge pull request #643 from madsboddum/equip_test_wait
...
Wait synchronously after broadcasting intents, to prevent race condit…
2022-07-10 17:20:35 -05:00
Ziggy
805fc3eb4f
Wait synchronously after broadcasting intents, to prevent race condition between ObjectCreatedIntent being processed too late by SimulatedObjectStorage
...
Hopefully this is why the tests are a bit flaky
2022-07-11 00:14:20 +02:00
Josh Larson
a61992ff8e
Merge pull request #642 from madsboddum/attack_cost_test
...
Created a test that verifies that health, action or mind is spent whe…
2022-07-10 17:04:58 -05:00
Ziggy
21cc40be1e
Created a test that verifies that health, action or mind is spent when a command requires it
...
Future addition could be that the command isn't executed if you're "too tired", which we have no support for now.
2022-07-11 00:00:38 +02:00
Ziggy