From 0833e3f7455ce6c9781fc41f824a563b670f6487 Mon Sep 17 00:00:00 2001 From: Matt Parnell Date: Wed, 20 Aug 2014 23:32:23 -0500 Subject: [PATCH] any time we call getResult, we likely re-parse the sql object. caching result item into a variable is more efficient --- src/services/ConnectionService.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/services/ConnectionService.java b/src/services/ConnectionService.java index 76a71558..7177d03c 100644 --- a/src/services/ConnectionService.java +++ b/src/services/ConnectionService.java @@ -128,15 +128,17 @@ public class ConnectionService implements INetworkDispatch { try { - preparedStatement = databaseConnection.preparedStatement("SELECT * FROM sessions WHERE key=?"); + preparedStatement = databaseConnection.preparedStatement("SELECT accountId FROM sessions WHERE key=?"); preparedStatement.setBytes(1, clientIdMsg.getSessionKey()); resultSet = preparedStatement.executeQuery(); if (resultSet.next()) { - client.setAccountId(resultSet.getLong("accountId")); + long accountId = resultSet.getLong("accountID"); + + client.setAccountId(accountId); client.setSessionKey(clientIdMsg.getSessionKey()); AccountFeatureBits accountFeatureBits = new AccountFeatureBits(); - ClientPermissionsMessage clientPermissionsMessage = new ClientPermissionsMessage(maxNumberOfCharacters - core.characterService.getNumberOfCharacters((int) resultSet.getLong("accountId"))); + ClientPermissionsMessage clientPermissionsMessage = new ClientPermissionsMessage(maxNumberOfCharacters - core.characterService.getNumberOfCharacters((int) accountId)); session.write(new HeartBeatMessage().serialize()); session.write(accountFeatureBits.serialize()); session.write(clientPermissionsMessage.serialize());