projectswg/NGECore2
1
0
Fork 0
mirror of https://github.com/ProjectSWGCore/NGECore2.git synced 2026-10-14 04:13:14 -04:00
Code Issues Projects Releases Wiki Activity

fix some SQL issues where we were grabbing way too much data than we needed for our results

Browse Source
This commit is contained in:
Matt Parnell
2014-08-18 23:02:58 -05:00
parent f7512b27c3
commit 1f899f9851
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/services/CharacterService.java
+8 -8
View File
@@ -527,7 +527,7 @@ public class CharacterService implements INetworkDispatch {
ResultSet resultSet = preparedStatement.executeQuery();
characters = 0;
if (resultSet.next() && !resultSet.isClosed())
if (!resultSet.isClosed() && resultSet.next())
characters = resultSet.getInt("charCount");
} catch (SQLException e) {
e.printStackTrace();
@@ -578,10 +578,10 @@ public class CharacterService implements INetworkDispatch {
name = name.toLowerCase();
long oid = 0L;
try {
PreparedStatement ps = databaseConnection.preparedStatement("SELECT * FROM characters WHERE LOWER(\"firstName\")=?");
PreparedStatement ps = databaseConnection.preparedStatement("SELECT COUNT(*) AS charCount FROM characters WHERE LOWER(\"firstName\")=?");
ps.setString(1, name);
ResultSet resultSet = ps.executeQuery();
while (resultSet.next()) {
if (!resultSet.isClosed() && resultSet.next()) {
oid = resultSet.getLong("id");
}
return oid;
@@ -601,7 +601,7 @@ public class CharacterService implements INetworkDispatch {
String name = "";
try {
PreparedStatement ps = databaseConnection.preparedStatement("SELECT * FROM characters WHERE \"id\"=?");
PreparedStatement ps = databaseConnection.preparedStatement("SELECT firstName FROM characters WHERE \"id\"=?");
ps.setLong(1, oid);
ResultSet resultSet = ps.executeQuery();
while (resultSet.next()) {
@@ -612,7 +612,7 @@ public class CharacterService implements INetworkDispatch {
}
name = name.toLowerCase();
}
}
return name;
}
@@ -651,11 +651,11 @@ public class CharacterService implements INetworkDispatch {
*/
public int getAccountId(long objectId) {
try {
PreparedStatement ps = databaseConnection.preparedStatement("SELECT * FROM characters WHERE id=?");
PreparedStatement ps = databaseConnection.preparedStatement("SELECT accountId FROM characters WHERE id=?");
ps.setLong(1, objectId);
ResultSet resultSet = ps.executeQuery();
resultSet.next();
return resultSet.getInt("accountId");
if (resultSet.next())
return resultSet.getInt("accountId");
} catch (SQLException e) {
e.printStackTrace();
}