From 465aed03b44c0b6235c48749b66be0aa5e7c3351 Mon Sep 17 00:00:00 2001 From: DarthArgus Date: Sat, 6 Aug 2016 03:22:16 +0000 Subject: [PATCH] remove unnecessary check --- .../application/LoginServer/src/shared/ClientConnection.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/engine/server/application/LoginServer/src/shared/ClientConnection.cpp b/engine/server/application/LoginServer/src/shared/ClientConnection.cpp index 4c2541fe..32b37a53 100755 --- a/engine/server/application/LoginServer/src/shared/ClientConnection.cpp +++ b/engine/server/application/LoginServer/src/shared/ClientConnection.cpp @@ -184,7 +184,10 @@ void ClientConnection::validateClient(const std::string & id, const std::string const webAPI::statusMessage response = webAPI::simplePost(authURL, std::string(postBuf.str()), "username"); - if (response.status && !response.retVal.empty()) + // true indicates that we logged in successfully via the api + // since both cases rely on response.retVal which will never be empty + // ...we needn't check if it's empty/not + if (response.status) { authOK = true; uname = response.retVal;