Update ChatAvatarService.cpp

2021-10-03 08:52:45 -04:00
parent c632be49e2
commit fe0e00c505
1 changed files with 8 additions and 5 deletions
--- a/src/stationchat/ChatAvatarService.cpp
+++ b/src/stationchat/ChatAvatarService.cpp
@@ -72,12 +72,15 @@ void ChatAvatarService::LoginAvatar(ChatAvatar* avatar) {
 }

 void ChatAvatarService::LogoutAvatar(ChatAvatar* avatar) {
+    if(avatar->isOnline_) // bug fix for redundant logout checks that cause crashes
+    {
        avatar->isOnline_ = false;

        onlineAvatars_.erase(std::remove_if(
            std::begin(onlineAvatars_), std::end(onlineAvatars_), [avatar](auto onlineAvatar) {
                return onlineAvatar->GetAvatarId() == avatar->GetAvatarId();
            }));
+    }
 }

 void ChatAvatarService::PersistAvatar(const ChatAvatar* avatar) { UpdateAvatar(avatar); }