remove unused/obsolete user privileges

This commit is contained in:
Spine
2025-06-11 08:43:05 +00:00
parent 9b940a8247
commit 8f46a185cb
5 changed files with 3 additions and 15 deletions

View File

@@ -172,7 +172,6 @@ class Privilege extends \Gazelle\BaseManager {
'site_debug' => 'Developer access',
'site_analysis' => 'Error analysis',
'site_database_specifics' => 'View database specifics',
'site_proxy_images' => 'Image proxy',
'site_search_many' => 'Go past low limit of search results',
'site_user_stats' => 'view user stat graphs',
'site_unlimit_ajax' => 'Bypass ajax api limits',
@@ -182,12 +181,10 @@ class Privilege extends \Gazelle\BaseManager {
'users_edit_ratio' => 'Edit upload/download amounts',
'users_edit_own_ratio' => 'Edit own upload/download amounts',
'users_edit_titles' => 'Edit user custom titles',
'users_edit_avatars' => 'Edit avatars',
'users_edit_reset_keys' => 'Reset user passkey/authkey',
'users_edit_profiles' => 'Edit user profiles',
'users_linked_users' => 'View and edit linked users',
'users_view_friends' => 'View user friends',
'users_reset_own_keys' => 'Reset own passkey/authkey',
'users_edit_password' => 'Edit passwords',
'users_promote_below' => 'Promote users to below own level',
'users_promote_to' => 'Promote users up to own level',
@@ -197,8 +194,6 @@ class Privilege extends \Gazelle\BaseManager {
'users_disable_posts' => 'Disable posting privileges',
'users_disable_any' => 'Disable any user privileges',
'users_delete_users' => 'Hard delete users',
'users_view_seedleech' => 'View user seeding/leeching',
'users_view_uploaded' => 'View user uploads',
'users_view_keys' => 'View passkeys',
'users_view_ips' => 'View IP addresses',
'users_view_email' => 'View email addresses',
@@ -219,7 +214,6 @@ class Privilege extends \Gazelle\BaseManager {
'admin_manage_news' => 'Manage site news',
'admin_manage_blog' => 'Manage the site blog',
'admin_manage_contest' => 'Manage contests',
'admin_manage_polls' => 'Manage front page polls',
'admin_manage_forums' => 'Manage forums departments',
'admin_manage_fls' => 'Manage First Line Support (FLS) crew',
'admin_manage_invite_source' => 'Manage invite sources',

View File

@@ -8,7 +8,7 @@ namespace Gazelle;
$siteLog = new Manager\SiteLog();
$page = (int)($_GET['page'] ?? 1);
if (!$Viewer->permitted('site_search_many')) {
if (!$Viewer->permitted('site_view_full_log')) {
$page = min($page, MAX_LOG_DEPTH / LOG_ENTRIES_PER_PAGE);
}

View File

@@ -104,16 +104,12 @@
{{ privilege(default, user, 'users_edit_ratio') }}
{{ privilege(default, user, 'users_edit_own_ratio') }}
{{ privilege(default, user, 'users_edit_titles') }}
{{ privilege(default, user, 'users_edit_avatars') }}
{{ privilege(default, user, 'users_edit_reset_keys') }}
{{ privilege(default, user, 'users_edit_profiles') }}
{{ privilege(default, user, 'users_reset_own_keys') }}
{{ privilege(default, user, 'users_edit_password') }}
{{ privilege(default, user, 'users_promote_below') }}
{{ privilege(default, user, 'users_promote_to') }}
{{ privilege(default, user, 'users_give_donor') }}
{{ privilege(default, user, 'users_view_seedleech') }}
{{ privilege(default, user, 'users_view_uploaded') }}
{{ privilege(default, user, 'users_view_keys') }}
{{ privilege(default, user, 'users_view_ips') }}
{{ privilege(default, user, 'users_view_email') }}
@@ -181,7 +177,6 @@
{{ privilege(default, user, 'site_view_torrent_snatchlist') }}
{{ privilege(default, user, 'site_delete_tag') }}
{{ privilege(default, user, 'site_disable_ip_history') }}
{{ privilege(default, user, 'site_proxy_images') }}
{{ privilege(default, user, 'site_tag_aliases_read') }}
{{ privilege(default, user, 'site_unlimit_ajax') }}
{{ privilege(default, user, 'site_archive_ajax') }}
@@ -197,7 +192,6 @@
{{ privilege(default, user, 'admin_manage_news') }}
{{ privilege(default, user, 'admin_manage_blog') }}
{{ privilege(default, user, 'admin_manage_contest') }}
{{ privilege(default, user, 'admin_manage_polls') }}
{{ privilege(default, user, 'admin_manage_fls') }}
{{ privilege(default, user, 'admin_manage_permissions') }}
{{ privilege(default, user, 'admin_manage_invite_source') }}

View File

@@ -39,7 +39,7 @@
{% endif %}
<a href="reports.php?action=report&amp;type=user&amp;id={{ user_id }}" class="brackets">Report user</a>
{% endif %}
{% if own_profile %}
{% if own_profile or viewer.permitted('users_view_friends') %}
<a href="friends.php" class="brackets">Friends</a>
{% endif %}
{% if viewer.permitted('admin_reports') %}

View File

@@ -32,7 +32,7 @@ class PrivilegeTest extends TestCase {
public function testPrivilegeCreate(): void {
$privilegeList = Manager\Privilege::privilegeList();
$this->assertCount(131, $privilegeList, 'privilege-total');
$this->assertCount(125, $privilegeList, 'privilege-total');
$manager = new Manager\Privilege();
$this->assertNull($manager->findByLevel(FAKE_LEVEL), 'privilege-find-none'); // if this fails, check the `permissions` table