chore(release): publish new version

- @standardnotes/home-server@1.11.6

.github/ci.env

@@ -4,6 +4,7 @@ DB_USERNAME=std_notes_user
 DB_PASSWORD=changeme123
 DB_DATABASE=standard_notes_db
 DB_PORT=3306
+DB_SQLITE_DATABASE_PATH=standard_notes_db
 REDIS_PORT=6379
 REDIS_HOST=cache
 AUTH_SERVER_ACCESS_TOKEN_AGE=4

packages/auth/CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.119.2](https://github.com/standardnotes/server/compare/@standardnotes/auth-server@1.119.1...@standardnotes/auth-server@1.119.2) (2023-06-14)
+
+### Bug Fixes
+
+* **home-server:** env var determining the sqlite database location ([#626](https://github.com/standardnotes/server/issues/626)) ([0cb5e36](https://github.com/standardnotes/server/commit/0cb5e36b20d9b095ea0edbcd877387e6c0069856))
+
 ## [1.119.1](https://github.com/standardnotes/server/compare/@standardnotes/auth-server@1.119.0...@standardnotes/auth-server@1.119.1) (2023-06-09)
 
 ### Bug Fixes

packages/auth/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@standardnotes/auth-server",
-  "version": "1.119.1",
+  "version": "1.119.2",
   "engines": {
     "node": ">=18.0.0 <21.0.0"
   },

packages/auth/src/Bootstrap/DataSource.ts

@@ -109,7 +109,7 @@ export class AppDataSource {
       const sqliteDataSourceOptions: SqliteConnectionOptions = {
         ...commonDataSourceOptions,
         type: 'sqlite',
-        database: this.env.get('DB_DATABASE'),
+        database: this.env.get('DB_SQLITE_DATABASE_PATH'),
       }
 
       this.dataSource = new DataSource(sqliteDataSourceOptions)

packages/files/CHANGELOG.md

@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.18.2](https://github.com/standardnotes/files/compare/@standardnotes/files-server@1.18.1...@standardnotes/files-server@1.18.2) (2023-06-12)
+
+### Bug Fixes
+
+* **home-server:** accept application/octet-stream requests for files ([#625](https://github.com/standardnotes/files/issues/625)) ([c8974b7](https://github.com/standardnotes/files/commit/c8974b7fa229ff4f1e026e1ebff50d1081cc5f8b))
+
+## [1.18.1](https://github.com/standardnotes/files/compare/@standardnotes/files-server@1.18.0...@standardnotes/files-server@1.18.1) (2023-06-09)
+
+### Bug Fixes
+
+* **files:** add debug logs for checking chunks upon finishing upload session ([5f0929c](https://github.com/standardnotes/files/commit/5f0929c1aa7b83661fb102bad34644db69ddf7eb))
+
 # [1.18.0](https://github.com/standardnotes/files/compare/@standardnotes/files-server@1.17.1...@standardnotes/files-server@1.18.0) (2023-06-05)
 
 ### Features

packages/files/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@standardnotes/files-server",
-  "version": "1.18.0",
+  "version": "1.18.2",
   "engines": {
     "node": ">=18.0.0 <21.0.0"
   },

packages/files/src/Domain/UseCase/UploadFileChunk/UploadFileChunk.spec.ts

@@ -26,6 +26,24 @@ describe('UploadFileChunk', () => {
     logger.warn = jest.fn()
   })
 
+  it('should not upload a data chunk with 0 bytes', async () => {
+    expect(
+      await createUseCase().execute({
+        chunkId: 2,
+        data: new Uint8Array([]),
+        resourceRemoteIdentifier: '2-3-4',
+        resourceUnencryptedFileSize: 123,
+        userUuid: '1-2-3',
+      }),
+    ).toEqual({
+      success: false,
+      message: 'Empty file chunk',
+    })
+
+    expect(fileUploader.uploadFileChunk).not.toHaveBeenCalled()
+    expect(uploadRepository.storeUploadChunkResult).not.toHaveBeenCalled()
+  })
+
   it('should not upload a data chunk to a non existing file upload session', async () => {
     uploadRepository.retrieveUploadSessionId = jest.fn().mockReturnValue(undefined)
 

packages/files/src/Domain/UseCase/UploadFileChunk/UploadFileChunk.ts

@@ -18,6 +18,17 @@ export class UploadFileChunk implements UseCaseInterface {
 
   async execute(dto: UploadFileChunkDTO): Promise<UploadFileChunkResponse> {
     try {
+      if (!dto.data.byteLength || dto.data.byteLength === 0) {
+        this.logger.debug(
+          `Skipping upload file chunk ${dto.chunkId} with 0 bytes for resource: ${dto.resourceRemoteIdentifier}`,
+        )
+
+        return {
+          success: false,
+          message: 'Empty file chunk',
+        }
+      }
+
       this.logger.debug(
         `Starting upload file chunk ${dto.chunkId} with ${dto.data.byteLength} bytes for resource: ${dto.resourceRemoteIdentifier}`,
       )

packages/files/src/Infra/FS/FSFileUploader.ts

@@ -39,7 +39,9 @@ export class FSFileUploader implements FileUploaderInterface {
       )
     }
 
-    this.logger.debug(`FS storing file chunk ${dto.chunkId} in memory for ${dto.uploadId}`)
+    this.logger.debug(
+      `FS storing file chunk ${dto.chunkId} in memory for ${dto.uploadId}: ${dto.data}, ${dto.data.byteLength}`,
+    )
 
     fileChunks.set(dto.chunkId, dto.data)
 
@@ -60,7 +62,14 @@ export class FSFileUploader implements FileUploaderInterface {
 
     const orderedKeys = [...fileChunks.keys()].sort((a, b) => a - b)
     for (const orderedKey of orderedKeys) {
-      await promises.appendFile(`${this.fileUploadPath}/${filePath}`, fileChunks.get(orderedKey) as Uint8Array)
+      const chunk = fileChunks.get(orderedKey)
+      if (!chunk || chunk.byteLength === 0) {
+        throw new Error(`Could not find chunk ${orderedKey} for upload ${uploadId}`)
+      }
+
+      this.logger.debug(`FS writing chunk ${orderedKey} for ${uploadId}: ${chunk.toString()} ${chunk.byteLength}}`)
+
+      await promises.appendFile(`${this.fileUploadPath}/${filePath}`, chunk)
     }
 
     this.inMemoryChunks.delete(uploadId)

packages/home-server/CHANGELOG.md

@@ -3,6 +3,34 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.11.6](https://github.com/standardnotes/server/compare/@standardnotes/home-server@1.11.5...@standardnotes/home-server@1.11.6) (2023-06-16)
+
+### Bug Fixes
+
+* **home-server:** unref the server instance when stopping the home server ([5ef90cc](https://github.com/standardnotes/server/commit/5ef90cc75b44133bf8065ce16f36d5b347c68122))
+
+## [1.11.5](https://github.com/standardnotes/server/compare/@standardnotes/home-server@1.11.4...@standardnotes/home-server@1.11.5) (2023-06-14)
+
+### Bug Fixes
+
+* **home-server:** env var determining the sqlite database location ([#626](https://github.com/standardnotes/server/issues/626)) ([0cb5e36](https://github.com/standardnotes/server/commit/0cb5e36b20d9b095ea0edbcd877387e6c0069856))
+
+## [1.11.4](https://github.com/standardnotes/server/compare/@standardnotes/home-server@1.11.3...@standardnotes/home-server@1.11.4) (2023-06-13)
+
+### Bug Fixes
+
+* **home-server:** encapsulate starting the server with a result return ([90a4f21](https://github.com/standardnotes/server/commit/90a4f2111f9e050e5fb500261c3e43eacc5622e4))
+
+## [1.11.3](https://github.com/standardnotes/server/compare/@standardnotes/home-server@1.11.2...@standardnotes/home-server@1.11.3) (2023-06-12)
+
+### Bug Fixes
+
+* **home-server:** accept application/octet-stream requests for files ([#625](https://github.com/standardnotes/server/issues/625)) ([c8974b7](https://github.com/standardnotes/server/commit/c8974b7fa229ff4f1e026e1ebff50d1081cc5f8b))
+
+## [1.11.2](https://github.com/standardnotes/server/compare/@standardnotes/home-server@1.11.1...@standardnotes/home-server@1.11.2) (2023-06-09)
+
+**Note:** Version bump only for package @standardnotes/home-server
+
 ## [1.11.1](https://github.com/standardnotes/server/compare/@standardnotes/home-server@1.11.0...@standardnotes/home-server@1.11.1) (2023-06-09)
 
 **Note:** Version bump only for package @standardnotes/home-server

packages/home-server/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@standardnotes/home-server",
-  "version": "1.11.1",
+  "version": "1.11.6",
   "engines": {
     "node": ">=18.0.0 <21.0.0"
   },

packages/home-server/src/Server/HomeServer.ts

@@ -12,7 +12,7 @@ import { InversifyExpressServer } from 'inversify-express-utils'
 import helmet from 'helmet'
 import * as cors from 'cors'
 import * as http from 'http'
-import { text, json, Request, Response, NextFunction } from 'express'
+import { text, json, Request, Response, NextFunction, raw } from 'express'
 import * as winston from 'winston'
 import { PassThrough } from 'stream'
 // eslint-disable-next-line @typescript-eslint/no-var-requires
@@ -27,122 +27,152 @@ export class HomeServer implements HomeServerInterface {
   private authService: AuthServiceInterface | undefined
   private logStream: PassThrough = new PassThrough()
 
-  async start(configuration: HomeServerConfiguration): Promise<void> {
-    const controllerContainer = new ControllerContainer()
-    const serviceContainer = new ServiceContainer()
-    const directCallDomainEventPublisher = new DirectCallDomainEventPublisher()
+  async start(configuration: HomeServerConfiguration): Promise<Result<string>> {
+    try {
+      const controllerContainer = new ControllerContainer()
+      const serviceContainer = new ServiceContainer()
+      const directCallDomainEventPublisher = new DirectCallDomainEventPublisher()
 
-    const environmentOverrides = {
-      DB_TYPE: 'sqlite',
-      CACHE_TYPE: 'memory',
-      DB_DATABASE: `${configuration.dataDirectoryPath}/database/home_server.sqlite`,
-      FILE_UPLOAD_PATH: `${configuration.dataDirectoryPath}/uploads`,
-      ...configuration.environment,
-      MODE: 'home-server',
-      NEW_RELIC_ENABLED: 'false',
-      NEW_RELIC_APP_NAME: 'Home Server',
-    }
+      const environmentOverrides = {
+        DB_TYPE: 'sqlite',
+        CACHE_TYPE: 'memory',
+        DB_SQLITE_DATABASE_PATH: `${configuration.dataDirectoryPath}/database/home_server.sqlite`,
+        FILE_UPLOAD_PATH: `${configuration.dataDirectoryPath}/uploads`,
+        ...configuration.environment,
+        MODE: 'home-server',
+        NEW_RELIC_ENABLED: 'false',
+        NEW_RELIC_APP_NAME: 'Home Server',
+      }
 
-    const env: Env = new Env(environmentOverrides)
-    env.load()
+      const env: Env = new Env(environmentOverrides)
+      env.load()
 
-    this.configureLoggers(env)
+      this.configureLoggers(env)
 
-    const apiGatewayService = new ApiGatewayService(serviceContainer)
-    const authService = new AuthService(serviceContainer, controllerContainer, directCallDomainEventPublisher)
-    this.authService = authService
-    const syncingService = new SyncingService(serviceContainer, controllerContainer, directCallDomainEventPublisher)
-    const revisionsService = new RevisionsService(serviceContainer, controllerContainer, directCallDomainEventPublisher)
-    const filesService = new FilesService(serviceContainer, directCallDomainEventPublisher)
+      const apiGatewayService = new ApiGatewayService(serviceContainer)
+      const authService = new AuthService(serviceContainer, controllerContainer, directCallDomainEventPublisher)
+      this.authService = authService
+      const syncingService = new SyncingService(serviceContainer, controllerContainer, directCallDomainEventPublisher)
+      const revisionsService = new RevisionsService(
+        serviceContainer,
+        controllerContainer,
+        directCallDomainEventPublisher,
+      )
+      const filesService = new FilesService(serviceContainer, directCallDomainEventPublisher)
 
-    const container = Container.merge(
-      (await apiGatewayService.getContainer({
-        logger: winston.loggers.get('api-gateway'),
-        environmentOverrides,
-      })) as Container,
-      (await authService.getContainer({
-        logger: winston.loggers.get('auth-server'),
-        environmentOverrides,
-      })) as Container,
-      (await syncingService.getContainer({
-        logger: winston.loggers.get('syncing-server'),
-        environmentOverrides,
-      })) as Container,
-      (await revisionsService.getContainer({
-        logger: winston.loggers.get('revisions-server'),
-        environmentOverrides,
-      })) as Container,
-      (await filesService.getContainer({
-        logger: winston.loggers.get('files-server'),
-        environmentOverrides,
-      })) as Container,
-    )
+      const container = Container.merge(
+        (await apiGatewayService.getContainer({
+          logger: winston.loggers.get('api-gateway'),
+          environmentOverrides,
+        })) as Container,
+        (await authService.getContainer({
+          logger: winston.loggers.get('auth-server'),
+          environmentOverrides,
+        })) as Container,
+        (await syncingService.getContainer({
+          logger: winston.loggers.get('syncing-server'),
+          environmentOverrides,
+        })) as Container,
+        (await revisionsService.getContainer({
+          logger: winston.loggers.get('revisions-server'),
+          environmentOverrides,
+        })) as Container,
+        (await filesService.getContainer({
+          logger: winston.loggers.get('files-server'),
+          environmentOverrides,
+        })) as Container,
+      )
 
-    const server = new InversifyExpressServer(container)
+      const server = new InversifyExpressServer(container)
 
-    server.setConfig((app) => {
-      /* eslint-disable */
-      app.use(helmet({
-        contentSecurityPolicy: {
-          directives: {
-            defaultSrc: ["https: 'self'"],
-            baseUri: ["'self'"],
-            childSrc: ["*", "blob:"],
-            connectSrc: ["*"],
-            fontSrc: ["*", "'self'"],
-            formAction: ["'self'"],
-            frameAncestors: ["*", "*.standardnotes.org", "*.standardnotes.com"],
-            frameSrc: ["*", "blob:"],
-            imgSrc: ["'self'", "*", "data:"],
-            manifestSrc: ["'self'"],
-            mediaSrc: ["'self'"],
-            objectSrc: ["'self'"],
-            scriptSrc: ["'self'"],
-            styleSrc: ["'self'"]
+      server.setConfig((app) => {
+        /* eslint-disable */
+        app.use(helmet({
+          contentSecurityPolicy: {
+            directives: {
+              defaultSrc: ["https: 'self'"],
+              baseUri: ["'self'"],
+              childSrc: ["*", "blob:"],
+              connectSrc: ["*"],
+              fontSrc: ["*", "'self'"],
+              formAction: ["'self'"],
+              frameAncestors: ["*", "*.standardnotes.org", "*.standardnotes.com"],
+              frameSrc: ["*", "blob:"],
+              imgSrc: ["'self'", "*", "data:"],
+              manifestSrc: ["'self'"],
+              mediaSrc: ["'self'"],
+              objectSrc: ["'self'"],
+              scriptSrc: ["'self'"],
+              styleSrc: ["'self'"]
+            }
           }
-        }
-      }))
-      /* eslint-enable */
-      app.use(json({ limit: '50mb' }))
-      app.use(
-        text({
-          type: ['text/plain', 'application/x-www-form-urlencoded', 'application/x-www-form-urlencoded; charset=utf-8'],
-        }),
-      )
-      app.use(cors())
-      app.use(
-        robots({
-          UserAgent: '*',
-          Disallow: '/',
-        }),
-      )
-    })
+        }))
+        /* eslint-enable */
+        app.use(json({ limit: '50mb' }))
+        app.use(raw({ limit: '50mb', type: 'application/octet-stream' }))
+        app.use(
+          text({
+            type: [
+              'text/plain',
+              'application/x-www-form-urlencoded',
+              'application/x-www-form-urlencoded; charset=utf-8',
+            ],
+          }),
+        )
+        app.use(
+          cors({
+            exposedHeaders: ['Content-Range', 'Accept-Ranges'],
+          }),
+        )
+        app.use(
+          robots({
+            UserAgent: '*',
+            Disallow: '/',
+          }),
+        )
+      })
 
-    const logger: winston.Logger = winston.loggers.get('home-server')
+      const logger: winston.Logger = winston.loggers.get('home-server')
 
-    server.setErrorConfig((app) => {
-      app.use((error: Record<string, unknown>, _request: Request, response: Response, _next: NextFunction) => {
-        logger.error(error.stack)
+      server.setErrorConfig((app) => {
+        app.use((error: Record<string, unknown>, _request: Request, response: Response, _next: NextFunction) => {
+          logger.error(error.stack)
 
-        response.status(500).send({
-          error: {
-            message:
-              "Unfortunately, we couldn't handle your request. Please try again or contact our support if the error persists.",
-          },
+          response.status(500).send({
+            error: {
+              message:
+                "Unfortunately, we couldn't handle your request. Please try again or contact our support if the error persists.",
+            },
+          })
         })
       })
-    })
 
-    const port = env.get('PORT', true) ? +env.get('PORT', true) : 3000
+      const port = env.get('PORT', true) ? +env.get('PORT', true) : 3000
 
-    this.serverInstance = server.build().listen(port)
+      this.serverInstance = server.build().listen(port)
 
-    logger.info(`Server started on port ${port}`)
+      logger.info(`Server started on port ${port}`)
+
+      return Result.ok('Server started.')
+    } catch (error) {
+      return Result.fail((error as Error).message)
+    }
   }
 
-  async stop(): Promise<void> {
-    if (this.serverInstance) {
+  async stop(): Promise<Result<string>> {
+    try {
+      if (!this.serverInstance) {
+        return Result.fail('Home server is not running.')
+      }
+
       this.serverInstance.close()
+      this.serverInstance.unref()
+
+      this.serverInstance = undefined
+
+      return Result.ok('Server stopped.')
+    } catch (error) {
+      return Result.fail((error as Error).message)
     }
   }
 

packages/home-server/src/Server/HomeServerInterface.ts

@@ -2,9 +2,9 @@ import { Result } from '@standardnotes/domain-core'
 import { HomeServerConfiguration } from './HomeServerConfiguration'
 
 export interface HomeServerInterface {
-  start(configuration?: HomeServerConfiguration): Promise<void>
+  start(configuration?: HomeServerConfiguration): Promise<Result<string>>
   activatePremiumFeatures(username: string): Promise<Result<string>>
-  stop(): Promise<void>
+  stop(): Promise<Result<string>>
   isRunning(): Promise<boolean>
   logs(): NodeJS.ReadableStream
 }

packages/revisions/CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.23.1](https://github.com/standardnotes/server/compare/@standardnotes/revisions-server@1.23.0...@standardnotes/revisions-server@1.23.1) (2023-06-14)
+
+### Bug Fixes
+
+* **home-server:** env var determining the sqlite database location ([#626](https://github.com/standardnotes/server/issues/626)) ([0cb5e36](https://github.com/standardnotes/server/commit/0cb5e36b20d9b095ea0edbcd877387e6c0069856))
+
 # [1.23.0](https://github.com/standardnotes/server/compare/@standardnotes/revisions-server@1.22.0...@standardnotes/revisions-server@1.23.0) (2023-06-07)
 
 ### Features

packages/revisions/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@standardnotes/revisions-server",
-  "version": "1.23.0",
+  "version": "1.23.1",
   "engines": {
     "node": ">=18.0.0 <21.0.0"
   },

packages/revisions/src/Bootstrap/DataSource.ts

@@ -79,7 +79,7 @@ export class AppDataSource {
       const sqliteDataSourceOptions: SqliteConnectionOptions = {
         ...commonDataSourceOptions,
         type: 'sqlite',
-        database: this.env.get('DB_DATABASE'),
+        database: this.env.get('DB_SQLITE_DATABASE_PATH'),
       }
 
       this.dataSource = new DataSource(sqliteDataSourceOptions)

packages/syncing-server/CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.44.1](https://github.com/standardnotes/syncing-server-js/compare/@standardnotes/syncing-server@1.44.0...@standardnotes/syncing-server@1.44.1) (2023-06-14)
+
+### Bug Fixes
+
+* **home-server:** env var determining the sqlite database location ([#626](https://github.com/standardnotes/syncing-server-js/issues/626)) ([0cb5e36](https://github.com/standardnotes/syncing-server-js/commit/0cb5e36b20d9b095ea0edbcd877387e6c0069856))
+
 # [1.44.0](https://github.com/standardnotes/syncing-server-js/compare/@standardnotes/syncing-server@1.43.0...@standardnotes/syncing-server@1.44.0) (2023-06-07)
 
 ### Features

packages/syncing-server/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@standardnotes/syncing-server",
-  "version": "1.44.0",
+  "version": "1.44.1",
   "engines": {
     "node": ">=18.0.0 <21.0.0"
   },

packages/syncing-server/src/Bootstrap/DataSource.ts

@@ -77,7 +77,7 @@ export class AppDataSource {
       const sqliteDataSourceOptions: SqliteConnectionOptions = {
         ...commonDataSourceOptions,
         type: 'sqlite',
-        database: this.env.get('DB_DATABASE'),
+        database: this.env.get('DB_SQLITE_DATABASE_PATH'),
       }
 
       this.dataSource = new DataSource(sqliteDataSourceOptions)