chore(deps): bump aws-actions/configure-aws-credentials from 3 to 4

Bumps [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials) from 3 to 4.
- [Release notes](https://github.com/aws-actions/configure-aws-credentials/releases)
- [Changelog](https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md)
- [Commits](https://github.com/aws-actions/configure-aws-credentials/compare/v3...v4)

---
updated-dependencies:
- dependency-name: aws-actions/configure-aws-credentials
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

.github/workflows/common-deploy.yml

@@ -24,7 +24,7 @@ jobs:
     steps:
 
     - name: Configure AWS credentials
-      uses: aws-actions/configure-aws-credentials@v3
+      uses: aws-actions/configure-aws-credentials@v4
       with:
         aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
         aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

.github/workflows/common-docker-image.yml

@@ -70,7 +70,7 @@ jobs:
         password: ${{ secrets.DOCKER_PASSWORD }}
 
     - name: Configure AWS credentials
-      uses: aws-actions/configure-aws-credentials@v3
+      uses: aws-actions/configure-aws-credentials@v4
       with:
         aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
         aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

packages/analytics/CHANGELOG.md

@@ -3,10 +3,6 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [2.26.15](https://github.com/standardnotes/server/compare/@standardnotes/analytics@2.26.14...@standardnotes/analytics@2.26.15) (2023-09-18)
-
-**Note:** Version bump only for package @standardnotes/analytics
-
 ## [2.26.14](https://github.com/standardnotes/server/compare/@standardnotes/analytics@2.26.13...@standardnotes/analytics@2.26.14) (2023-09-15)
 
 **Note:** Version bump only for package @standardnotes/analytics

packages/analytics/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@standardnotes/analytics",
-  "version": "2.26.15",
+  "version": "2.26.14",
   "engines": {
     "node": ">=18.0.0 <21.0.0"
   },

packages/api-gateway/CHANGELOG.md

@@ -3,10 +3,6 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [1.74.13](https://github.com/standardnotes/api-gateway/compare/@standardnotes/api-gateway@1.74.12...@standardnotes/api-gateway@1.74.13) (2023-09-18)
-
-**Note:** Version bump only for package @standardnotes/api-gateway
-
 ## [1.74.12](https://github.com/standardnotes/api-gateway/compare/@standardnotes/api-gateway@1.74.11...@standardnotes/api-gateway@1.74.12) (2023-09-15)
 
 **Note:** Version bump only for package @standardnotes/api-gateway

packages/api-gateway/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@standardnotes/api-gateway",
-  "version": "1.74.13",
+  "version": "1.74.12",
   "engines": {
     "node": ">=18.0.0 <21.0.0"
   },

packages/auth/CHANGELOG.md

@@ -3,10 +3,6 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [1.143.2](https://github.com/standardnotes/server/compare/@standardnotes/auth-server@1.143.1...@standardnotes/auth-server@1.143.2) (2023-09-18)
-
-**Note:** Version bump only for package @standardnotes/auth-server
-
 ## [1.143.1](https://github.com/standardnotes/server/compare/@standardnotes/auth-server@1.143.0...@standardnotes/auth-server@1.143.1) (2023-09-15)
 
 ### Bug Fixes

packages/auth/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@standardnotes/auth-server",
-  "version": "1.143.2",
+  "version": "1.143.1",
   "engines": {
     "node": ">=18.0.0 <21.0.0"
   },

packages/domain-core/CHANGELOG.md

@@ -3,12 +3,6 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-# [1.30.0](https://github.com/standardnotes/server/compare/@standardnotes/domain-core@1.29.0...@standardnotes/domain-core@1.30.0) (2023-09-18)
-
-### Features
-
-* add publishing notifications for users when a user is added to vault ([#834](https://github.com/standardnotes/server/issues/834)) ([547a79e](https://github.com/standardnotes/server/commit/547a79e23174dab0a756e4e5bee218e4859b3b42))
-
 # [1.29.0](https://github.com/standardnotes/server/compare/@standardnotes/domain-core@1.28.1...@standardnotes/domain-core@1.29.0) (2023-09-15)
 
 ### Features

packages/domain-core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@standardnotes/domain-core",
-  "version": "1.30.0",
+  "version": "1.29.0",
   "engines": {
     "node": ">=18.0.0 <21.0.0"
   },

packages/domain-core/src/Domain/Notification/NotificationType.ts

@@ -6,7 +6,6 @@ export class NotificationType extends ValueObject<NotificationTypeProps> {
   static readonly TYPES = {
     SharedVaultItemRemoved: 'shared_vault_item_removed',
     RemovedFromSharedVault: 'removed_from_shared_vault',
-    UserAddedToSharedVault: 'user_added_to_shared_vault',
     SharedVaultFileUploaded: 'shared_vault_file_uploaded',
     SharedVaultFileRemoved: 'shared_vault_file_removed',
   }

packages/event-store/CHANGELOG.md

@@ -3,10 +3,6 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [1.11.43](https://github.com/standardnotes/server/compare/@standardnotes/event-store@1.11.42...@standardnotes/event-store@1.11.43) (2023-09-18)
-
-**Note:** Version bump only for package @standardnotes/event-store
-
 ## [1.11.42](https://github.com/standardnotes/server/compare/@standardnotes/event-store@1.11.41...@standardnotes/event-store@1.11.42) (2023-09-15)
 
 **Note:** Version bump only for package @standardnotes/event-store

packages/event-store/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@standardnotes/event-store",
-  "version": "1.11.43",
+  "version": "1.11.42",
   "description": "Event Store Service",
   "private": true,
   "main": "dist/src/index.js",

packages/files/CHANGELOG.md

@@ -3,10 +3,6 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [1.22.22](https://github.com/standardnotes/files/compare/@standardnotes/files-server@1.22.21...@standardnotes/files-server@1.22.22) (2023-09-18)
-
-**Note:** Version bump only for package @standardnotes/files-server
-
 ## [1.22.21](https://github.com/standardnotes/files/compare/@standardnotes/files-server@1.22.20...@standardnotes/files-server@1.22.21) (2023-09-15)
 
 **Note:** Version bump only for package @standardnotes/files-server

packages/files/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@standardnotes/files-server",
-  "version": "1.22.22",
+  "version": "1.22.21",
   "engines": {
     "node": ">=18.0.0 <21.0.0"
   },

packages/home-server/CHANGELOG.md

@@ -3,10 +3,6 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [1.15.60](https://github.com/standardnotes/server/compare/@standardnotes/home-server@1.15.59...@standardnotes/home-server@1.15.60) (2023-09-18)
-
-**Note:** Version bump only for package @standardnotes/home-server
-
 ## [1.15.59](https://github.com/standardnotes/server/compare/@standardnotes/home-server@1.15.58...@standardnotes/home-server@1.15.59) (2023-09-15)
 
 **Note:** Version bump only for package @standardnotes/home-server

packages/home-server/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@standardnotes/home-server",
-  "version": "1.15.60",
+  "version": "1.15.59",
   "engines": {
     "node": ">=18.0.0 <21.0.0"
   },

packages/revisions/CHANGELOG.md

@@ -3,10 +3,6 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [1.35.1](https://github.com/standardnotes/server/compare/@standardnotes/revisions-server@1.35.0...@standardnotes/revisions-server@1.35.1) (2023-09-18)
-
-**Note:** Version bump only for package @standardnotes/revisions-server
-
 # [1.35.0](https://github.com/standardnotes/server/compare/@standardnotes/revisions-server@1.34.1...@standardnotes/revisions-server@1.35.0) (2023-09-15)
 
 ### Features

packages/revisions/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@standardnotes/revisions-server",
-  "version": "1.35.1",
+  "version": "1.35.0",
   "engines": {
     "node": ">=18.0.0 <21.0.0"
   },

packages/scheduler/CHANGELOG.md

@@ -3,10 +3,6 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [1.20.47](https://github.com/standardnotes/server/compare/@standardnotes/scheduler-server@1.20.46...@standardnotes/scheduler-server@1.20.47) (2023-09-18)
-
-**Note:** Version bump only for package @standardnotes/scheduler-server
-
 ## [1.20.46](https://github.com/standardnotes/server/compare/@standardnotes/scheduler-server@1.20.45...@standardnotes/scheduler-server@1.20.46) (2023-09-15)
 
 **Note:** Version bump only for package @standardnotes/scheduler-server

packages/scheduler/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@standardnotes/scheduler-server",
-  "version": "1.20.47",
+  "version": "1.20.46",
   "engines": {
     "node": ">=18.0.0 <21.0.0"
   },

packages/settings/CHANGELOG.md

@@ -3,10 +3,6 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [1.21.33](https://github.com/standardnotes/server/compare/@standardnotes/settings@1.21.32...@standardnotes/settings@1.21.33) (2023-09-18)
-
-**Note:** Version bump only for package @standardnotes/settings
-
 ## [1.21.32](https://github.com/standardnotes/server/compare/@standardnotes/settings@1.21.31...@standardnotes/settings@1.21.32) (2023-09-15)
 
 **Note:** Version bump only for package @standardnotes/settings

packages/settings/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@standardnotes/settings",
-  "version": "1.21.33",
+  "version": "1.21.32",
   "engines": {
     "node": ">=18.0.0 <21.0.0"
   },

packages/syncing-server/CHANGELOG.md

@@ -3,12 +3,6 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-# [1.98.0](https://github.com/standardnotes/syncing-server-js/compare/@standardnotes/syncing-server@1.97.0...@standardnotes/syncing-server@1.98.0) (2023-09-18)
-
-### Features
-
-* add publishing notifications for users when a user is added to vault ([#834](https://github.com/standardnotes/syncing-server-js/issues/834)) ([547a79e](https://github.com/standardnotes/syncing-server-js/commit/547a79e23174dab0a756e4e5bee218e4859b3b42))
-
 # [1.97.0](https://github.com/standardnotes/syncing-server-js/compare/@standardnotes/syncing-server@1.96.1...@standardnotes/syncing-server@1.97.0) (2023-09-15)
 
 ### Features

packages/syncing-server/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@standardnotes/syncing-server",
-  "version": "1.98.0",
+  "version": "1.97.0",
   "engines": {
     "node": ">=18.0.0 <21.0.0"
   },

packages/syncing-server/src/Bootstrap/Container.ts

@@ -620,14 +620,14 @@ export class ContainerConfigLoader {
       .bind<UpdateExistingItem>(TYPES.Sync_UpdateExistingItem)
       .toConstantValue(
         new UpdateExistingItem(
-          container.get<ItemRepositoryResolverInterface>(TYPES.Sync_ItemRepositoryResolver),
-          container.get<TimerInterface>(TYPES.Sync_Timer),
-          container.get<DomainEventPublisherInterface>(TYPES.Sync_DomainEventPublisher),
-          container.get<DomainEventFactoryInterface>(TYPES.Sync_DomainEventFactory),
-          container.get<number>(TYPES.Sync_REVISIONS_FREQUENCY),
-          container.get<DetermineSharedVaultOperationOnItem>(TYPES.Sync_DetermineSharedVaultOperationOnItem),
-          container.get<AddNotificationsForUsers>(TYPES.Sync_AddNotificationsForUsers),
-          container.get<RemoveNotificationsForUser>(TYPES.Sync_RemoveNotificationsForUser),
+          container.get(TYPES.Sync_ItemRepositoryResolver),
+          container.get(TYPES.Sync_Timer),
+          container.get(TYPES.Sync_DomainEventPublisher),
+          container.get(TYPES.Sync_DomainEventFactory),
+          container.get(TYPES.Sync_REVISIONS_FREQUENCY),
+          container.get(TYPES.Sync_DetermineSharedVaultOperationOnItem),
+          container.get(TYPES.Sync_AddNotificationForUser),
+          container.get(TYPES.Sync_RemoveNotificationsForUser),
         ),
       )
     container
@@ -710,7 +710,6 @@ export class ContainerConfigLoader {
           container.get<TimerInterface>(TYPES.Sync_Timer),
           container.get<DomainEventFactoryInterface>(TYPES.Sync_DomainEventFactory),
           container.get<DomainEventPublisherInterface>(TYPES.Sync_DomainEventPublisher),
-          container.get<AddNotificationsForUsers>(TYPES.Sync_AddNotificationsForUsers),
         ),
       )
     container
@@ -757,7 +756,7 @@ export class ContainerConfigLoader {
         new RemoveUserFromSharedVault(
           container.get<SharedVaultUserRepositoryInterface>(TYPES.Sync_SharedVaultUserRepository),
           container.get<SharedVaultRepositoryInterface>(TYPES.Sync_SharedVaultRepository),
-          container.get<AddNotificationsForUsers>(TYPES.Sync_AddNotificationsForUsers),
+          container.get<AddNotificationForUser>(TYPES.Sync_AddNotificationForUser),
           container.get<DomainEventFactoryInterface>(TYPES.Sync_DomainEventFactory),
           container.get<DomainEventPublisherInterface>(TYPES.Sync_DomainEventPublisher),
         ),

packages/syncing-server/src/Domain/UseCase/SharedVaults/AddUserToSharedVault/AddUserToSharedVault.spec.ts

@@ -1,5 +1,5 @@
 import { TimerInterface } from '@standardnotes/time'
-import { NotificationPayload, Result, SharedVaultUser } from '@standardnotes/domain-core'
+import { Result, SharedVaultUser } from '@standardnotes/domain-core'
 import { DomainEventInterface, DomainEventPublisherInterface } from '@standardnotes/domain-events'
 
 import { SharedVaultRepositoryInterface } from '../../../SharedVault/SharedVaultRepositoryInterface'
@@ -7,7 +7,6 @@ import { SharedVaultUserRepositoryInterface } from '../../../SharedVault/User/Sh
 import { AddUserToSharedVault } from './AddUserToSharedVault'
 import { SharedVault } from '../../../SharedVault/SharedVault'
 import { DomainEventFactoryInterface } from '../../../Event/DomainEventFactoryInterface'
-import { AddNotificationsForUsers } from '../../Messaging/AddNotificationsForUsers/AddNotificationsForUsers'
 
 describe('AddUserToSharedVault', () => {
   let sharedVaultRepository: SharedVaultRepositoryInterface
@@ -16,7 +15,6 @@ describe('AddUserToSharedVault', () => {
   let sharedVault: SharedVault
   let domainEventFactory: DomainEventFactoryInterface
   let domainEventPublisher: DomainEventPublisherInterface
-  let addNotificationsForUsers: AddNotificationsForUsers
 
   const validUuid = '00000000-0000-0000-0000-000000000000'
 
@@ -27,7 +25,6 @@ describe('AddUserToSharedVault', () => {
       timer,
       domainEventFactory,
       domainEventPublisher,
-      addNotificationsForUsers,
     )
 
   beforeEach(() => {
@@ -49,9 +46,6 @@ describe('AddUserToSharedVault', () => {
 
     domainEventPublisher = {} as jest.Mocked<DomainEventPublisherInterface>
     domainEventPublisher.publish = jest.fn()
-
-    addNotificationsForUsers = {} as jest.Mocked<AddNotificationsForUsers>
-    addNotificationsForUsers.execute = jest.fn().mockReturnValue(Result.ok())
   })
 
   it('should return a failure result if the shared vault uuid is invalid', async () => {
@@ -128,39 +122,6 @@ describe('AddUserToSharedVault', () => {
     mockSharedVaultUser.mockRestore()
   })
 
-  it('should return a failure if add notification for users fails', async () => {
-    addNotificationsForUsers.execute = jest.fn().mockReturnValue(Result.fail('Oops'))
-
-    const useCase = createUseCase()
-
-    const result = await useCase.execute({
-      sharedVaultUuid: validUuid,
-      userUuid: validUuid,
-      permission: 'read',
-    })
-
-    expect(result.isFailed()).toBe(true)
-    expect(result.getError()).toBe('Oops')
-  })
-
-  it('should return error if notification payload could not be created', async () => {
-    const mock = jest.spyOn(NotificationPayload, 'create')
-    mock.mockReturnValue(Result.fail('Oops'))
-
-    const useCase = createUseCase()
-
-    const result = await useCase.execute({
-      sharedVaultUuid: validUuid,
-      userUuid: validUuid,
-      permission: 'read',
-    })
-
-    expect(result.isFailed()).toBe(true)
-    expect(result.getError()).toBe('Oops')
-
-    mock.mockRestore()
-  })
-
   it('should add a user to a shared vault', async () => {
     const useCase = createUseCase()
 

packages/syncing-server/src/Domain/UseCase/SharedVaults/AddUserToSharedVault/AddUserToSharedVault.ts

@@ -1,6 +1,4 @@
 import {
-  NotificationPayload,
-  NotificationType,
   Result,
   SharedVaultUser,
   SharedVaultUserPermission,
@@ -15,7 +13,6 @@ import { AddUserToSharedVaultDTO } from './AddUserToSharedVaultDTO'
 import { SharedVaultRepositoryInterface } from '../../../SharedVault/SharedVaultRepositoryInterface'
 import { SharedVaultUserRepositoryInterface } from '../../../SharedVault/User/SharedVaultUserRepositoryInterface'
 import { DomainEventFactoryInterface } from '../../../Event/DomainEventFactoryInterface'
-import { AddNotificationsForUsers } from '../../Messaging/AddNotificationsForUsers/AddNotificationsForUsers'
 
 export class AddUserToSharedVault implements UseCaseInterface<SharedVaultUser> {
   constructor(
@@ -24,7 +21,6 @@ export class AddUserToSharedVault implements UseCaseInterface<SharedVaultUser> {
     private timer: TimerInterface,
     private domainEventFactory: DomainEventFactoryInterface,
     private domainEventPublisher: DomainEventPublisherInterface,
-    private addNotificationForUsers: AddNotificationsForUsers,
   ) {}
 
   async execute(dto: AddUserToSharedVaultDTO): Promise<Result<SharedVaultUser>> {
@@ -71,26 +67,6 @@ export class AddUserToSharedVault implements UseCaseInterface<SharedVaultUser> {
 
     await this.sharedVaultUserRepository.save(sharedVaultUser)
 
-    const notificationPayloadOrError = NotificationPayload.create({
-      sharedVaultUuid: sharedVaultUuid,
-      type: NotificationType.create(NotificationType.TYPES.UserAddedToSharedVault).getValue(),
-      version: '1.0',
-    })
-    if (notificationPayloadOrError.isFailed()) {
-      return Result.fail(notificationPayloadOrError.getError())
-    }
-    const notificationPayload = notificationPayloadOrError.getValue()
-
-    const result = await this.addNotificationForUsers.execute({
-      sharedVaultUuid: sharedVaultUuid.value,
-      type: NotificationType.TYPES.UserAddedToSharedVault,
-      payload: notificationPayload,
-      version: '1.0',
-    })
-    if (result.isFailed()) {
-      return Result.fail(result.getError())
-    }
-
     await this.domainEventPublisher.publish(
       this.domainEventFactory.createUserAddedToSharedVaultEvent({
         sharedVaultUuid: sharedVaultUser.props.sharedVaultUuid.value,

packages/syncing-server/src/Domain/UseCase/SharedVaults/RemoveUserFromSharedVault/RemoveUserFromSharedVault.spec.ts

@@ -11,14 +11,14 @@ import { SharedVault } from '../../../SharedVault/SharedVault'
 import { SharedVaultRepositoryInterface } from '../../../SharedVault/SharedVaultRepositoryInterface'
 import { SharedVaultUserRepositoryInterface } from '../../../SharedVault/User/SharedVaultUserRepositoryInterface'
 import { RemoveUserFromSharedVault } from './RemoveUserFromSharedVault'
+import { AddNotificationForUser } from '../../Messaging/AddNotificationForUser/AddNotificationForUser'
 import { DomainEventFactoryInterface } from '../../../Event/DomainEventFactoryInterface'
 import { DomainEventInterface, DomainEventPublisherInterface } from '@standardnotes/domain-events'
-import { AddNotificationsForUsers } from '../../Messaging/AddNotificationsForUsers/AddNotificationsForUsers'
 
 describe('RemoveUserFromSharedVault', () => {
   let sharedVaultRepository: SharedVaultRepositoryInterface
   let sharedVaultUserRepository: SharedVaultUserRepositoryInterface
-  let addNotificationsForUsers: AddNotificationsForUsers
+  let addNotificationForUser: AddNotificationForUser
   let sharedVault: SharedVault
   let sharedVaultUser: SharedVaultUser
   let domainEventFactory: DomainEventFactoryInterface
@@ -28,7 +28,7 @@ describe('RemoveUserFromSharedVault', () => {
     new RemoveUserFromSharedVault(
       sharedVaultUserRepository,
       sharedVaultRepository,
-      addNotificationsForUsers,
+      addNotificationForUser,
       domainEventFactory,
       domainEventPublisher,
     )
@@ -53,8 +53,8 @@ describe('RemoveUserFromSharedVault', () => {
     sharedVaultUserRepository.findByUserUuidAndSharedVaultUuid = jest.fn().mockResolvedValue(sharedVaultUser)
     sharedVaultUserRepository.remove = jest.fn()
 
-    addNotificationsForUsers = {} as jest.Mocked<AddNotificationsForUsers>
-    addNotificationsForUsers.execute = jest.fn().mockReturnValue(Result.ok())
+    addNotificationForUser = {} as jest.Mocked<AddNotificationForUser>
+    addNotificationForUser.execute = jest.fn().mockReturnValue(Result.ok())
 
     domainEventFactory = {} as jest.Mocked<DomainEventFactoryInterface>
     domainEventFactory.createUserRemovedFromSharedVaultEvent = jest
@@ -199,11 +199,11 @@ describe('RemoveUserFromSharedVault', () => {
       userUuid: '00000000-0000-0000-0000-000000000001',
     })
 
-    expect(addNotificationsForUsers.execute).toHaveBeenCalled()
+    expect(addNotificationForUser.execute).toHaveBeenCalled()
   })
 
   it('should return error if notification could not be added', async () => {
-    addNotificationsForUsers.execute = jest.fn().mockResolvedValue(Result.fail('Could not add notification'))
+    addNotificationForUser.execute = jest.fn().mockResolvedValue(Result.fail('Could not add notification'))
 
     const useCase = createUseCase()
     const result = await useCase.execute({
@@ -228,7 +228,5 @@ describe('RemoveUserFromSharedVault', () => {
 
     expect(result.isFailed()).toBe(true)
     expect(result.getError()).toBe('Oops')
-
-    mock.mockRestore()
   })
 })

packages/syncing-server/src/Domain/UseCase/SharedVaults/RemoveUserFromSharedVault/RemoveUserFromSharedVault.ts

@@ -4,14 +4,14 @@ import { DomainEventPublisherInterface } from '@standardnotes/domain-events'
 import { RemoveUserFromSharedVaultDTO } from './RemoveUserFromSharedVaultDTO'
 import { SharedVaultRepositoryInterface } from '../../../SharedVault/SharedVaultRepositoryInterface'
 import { SharedVaultUserRepositoryInterface } from '../../../SharedVault/User/SharedVaultUserRepositoryInterface'
+import { AddNotificationForUser } from '../../Messaging/AddNotificationForUser/AddNotificationForUser'
 import { DomainEventFactoryInterface } from '../../../Event/DomainEventFactoryInterface'
-import { AddNotificationsForUsers } from '../../Messaging/AddNotificationsForUsers/AddNotificationsForUsers'
 
 export class RemoveUserFromSharedVault implements UseCaseInterface<void> {
   constructor(
     private sharedVaultUsersRepository: SharedVaultUserRepositoryInterface,
     private sharedVaultRepository: SharedVaultRepositoryInterface,
-    private addNotificationForUsers: AddNotificationsForUsers,
+    private addNotificationForUser: AddNotificationForUser,
     private domainEventFactory: DomainEventFactoryInterface,
     private domainEventPublisher: DomainEventPublisherInterface,
   ) {}
@@ -71,8 +71,8 @@ export class RemoveUserFromSharedVault implements UseCaseInterface<void> {
     }
     const notificationPayload = notificationPayloadOrError.getValue()
 
-    const result = await this.addNotificationForUsers.execute({
-      sharedVaultUuid: sharedVault.id.toString(),
+    const result = await this.addNotificationForUser.execute({
+      userUuid: sharedVaultUser.props.userUuid.value,
       type: NotificationType.TYPES.RemovedFromSharedVault,
       payload: notificationPayload,
       version: '1.0',

packages/syncing-server/src/Domain/UseCase/Syncing/UpdateExistingItem/UpdateExistingItem.spec.ts

@@ -18,10 +18,10 @@ import {
 import { SharedVaultAssociation } from '../../../SharedVault/SharedVaultAssociation'
 import { KeySystemAssociation } from '../../../KeySystem/KeySystemAssociation'
 import { DetermineSharedVaultOperationOnItem } from '../../SharedVaults/DetermineSharedVaultOperationOnItem/DetermineSharedVaultOperationOnItem'
+import { AddNotificationForUser } from '../../Messaging/AddNotificationForUser/AddNotificationForUser'
 import { RemoveNotificationsForUser } from '../../Messaging/RemoveNotificationsForUser/RemoveNotificationsForUser'
 import { SharedVaultOperationOnItem } from '../../../SharedVault/SharedVaultOperationOnItem'
 import { ItemRepositoryResolverInterface } from '../../../Item/ItemRepositoryResolverInterface'
-import { AddNotificationsForUsers } from '../../Messaging/AddNotificationsForUsers/AddNotificationsForUsers'
 
 describe('UpdateExistingItem', () => {
   let itemRepository: ItemRepositoryInterface
@@ -32,7 +32,7 @@ describe('UpdateExistingItem', () => {
   let itemHash1: ItemHash
   let item1: Item
   let determineSharedVaultOperationOnItem: DetermineSharedVaultOperationOnItem
-  let addNotificationsForUsers: AddNotificationsForUsers
+  let addNotificationForUser: AddNotificationForUser
   let removeNotificationsForUser: RemoveNotificationsForUser
 
   const createUseCase = () =>
@@ -43,7 +43,7 @@ describe('UpdateExistingItem', () => {
       domainEventFactory,
       5,
       determineSharedVaultOperationOnItem,
-      addNotificationsForUsers,
+      addNotificationForUser,
       removeNotificationsForUser,
     )
 
@@ -128,8 +128,8 @@ describe('UpdateExistingItem', () => {
       ),
     )
 
-    addNotificationsForUsers = {} as jest.Mocked<AddNotificationsForUsers>
-    addNotificationsForUsers.execute = jest.fn().mockReturnValue(Result.ok())
+    addNotificationForUser = {} as jest.Mocked<AddNotificationForUser>
+    addNotificationForUser.execute = jest.fn().mockReturnValue(Result.ok())
 
     removeNotificationsForUser = {} as jest.Mocked<RemoveNotificationsForUser>
     removeNotificationsForUser.execute = jest.fn().mockReturnValue(Result.ok())
@@ -580,7 +580,7 @@ describe('UpdateExistingItem', () => {
         ),
       )
 
-      addNotificationsForUsers.execute = jest.fn().mockReturnValue(Result.fail('Oops'))
+      addNotificationForUser.execute = jest.fn().mockReturnValue(Result.fail('Oops'))
 
       const useCase = createUseCase()
 

packages/syncing-server/src/Domain/UseCase/Syncing/UpdateExistingItem/UpdateExistingItem.ts

@@ -20,10 +20,10 @@ import { SharedVaultAssociation } from '../../../SharedVault/SharedVaultAssociat
 import { KeySystemAssociation } from '../../../KeySystem/KeySystemAssociation'
 import { DetermineSharedVaultOperationOnItem } from '../../SharedVaults/DetermineSharedVaultOperationOnItem/DetermineSharedVaultOperationOnItem'
 import { SharedVaultOperationOnItem } from '../../../SharedVault/SharedVaultOperationOnItem'
+import { AddNotificationForUser } from '../../Messaging/AddNotificationForUser/AddNotificationForUser'
 import { RemoveNotificationsForUser } from '../../Messaging/RemoveNotificationsForUser/RemoveNotificationsForUser'
 import { ItemRepositoryResolverInterface } from '../../../Item/ItemRepositoryResolverInterface'
 import { ItemHash } from '../../../Item/ItemHash'
-import { AddNotificationsForUsers } from '../../Messaging/AddNotificationsForUsers/AddNotificationsForUsers'
 
 export class UpdateExistingItem implements UseCaseInterface<Item> {
   constructor(
@@ -33,7 +33,7 @@ export class UpdateExistingItem implements UseCaseInterface<Item> {
     private domainEventFactory: DomainEventFactoryInterface,
     private revisionFrequency: number,
     private determineSharedVaultOperationOnItem: DetermineSharedVaultOperationOnItem,
-    private addNotificationForUsers: AddNotificationsForUsers,
+    private addNotificationForUser: AddNotificationForUser,
     private removeNotificationsForUser: RemoveNotificationsForUser,
   ) {}
 
@@ -255,10 +255,10 @@ export class UpdateExistingItem implements UseCaseInterface<Item> {
       }
       const payload = notificationPayloadOrError.getValue()
 
-      const result = await this.addNotificationForUsers.execute({
+      const result = await this.addNotificationForUser.execute({
         payload,
         type: NotificationType.TYPES.SharedVaultItemRemoved,
-        sharedVaultUuid: sharedVaultOperation.props.sharedVaultUuid.value,
+        userUuid: userUuid.value,
         version: '1.0',
       })
       if (result.isFailed()) {

packages/websockets/CHANGELOG.md

@@ -3,10 +3,6 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [1.10.44](https://github.com/standardnotes/server/compare/@standardnotes/websockets-server@1.10.43...@standardnotes/websockets-server@1.10.44) (2023-09-18)
-
-**Note:** Version bump only for package @standardnotes/websockets-server
-
 ## [1.10.43](https://github.com/standardnotes/server/compare/@standardnotes/websockets-server@1.10.42...@standardnotes/websockets-server@1.10.43) (2023-09-15)
 
 **Note:** Version bump only for package @standardnotes/websockets-server

packages/websockets/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@standardnotes/websockets-server",
-  "version": "1.10.44",
+  "version": "1.10.43",
   "engines": {
     "node": ">=18.0.0 <21.0.0"
   },