Optimized some string concatenations in RelationalServerData

src/resources/server_info/RelationalServerData.java

@@ -29,14 +29,18 @@ package resources.server_info;
 
 import java.io.BufferedReader;
 import java.io.File;
-import java.io.FileReader;
+import java.io.FileInputStream;
 import java.io.IOException;
+import java.io.InputStreamReader;
+import java.nio.charset.Charset;
 import java.sql.PreparedStatement;
 import java.sql.ResultSet;
 import java.sql.SQLException;
 
 public class RelationalServerData extends RelationalDatabase {
 	
+	private static final Charset ASCII = Charset.forName("ASCII");
+	
 	private static final String META_TABLE = "__server_table_metadata__";
 	private final PreparedStatement getTableMetadata;
 	private final PreparedStatement updateTableMetadata;
@@ -136,7 +140,7 @@ public class RelationalServerData extends RelationalDatabase {
 	}
 	
 	private void processSdb(String table, File file) throws IOException, SQLException {
-		BufferedReader reader = new BufferedReader(new FileReader(file));
+		BufferedReader reader = new BufferedReader(new InputStreamReader(new FileInputStream(file), ASCII));
 		String line = null;
 		String [] columnNames = null;
 		String [] columnTypes = null;
@@ -163,25 +167,27 @@ public class RelationalServerData extends RelationalDatabase {
 	private void createTable(String table, String [] names, String [] types) {
 		if (names.length != types.length)
 			throw new IllegalArgumentException("Names length and Types length mismatch");
-		String sql = "CREATE TABLE "+table+" (";
+		StringBuilder sql = new StringBuilder("CREATE TABLE "+table+" (");
 		for (int i = 0; i < names.length; i++) {
 			if (i > 0)
-				sql += ", ";
-			sql += names[i] + " " + types[i];
+				sql.append(", ");
+			sql.append(names[i]);
+			sql.append(' ');
+			sql.append(types[i]);
 		}
-		sql += ")";
-		updateQuery(sql);
+		sql.append(')');
+		updateQuery(sql.toString());
 	}
 	
 	private String createPreparedStatement(String table, int valueSize) {
-		String sql = "INSERT INTO " + table + " VALUES (";
+		StringBuilder sql = new StringBuilder("INSERT INTO " + table + " VALUES (");
 		for (int i = 0; i < valueSize; i++) {
 			if (i > 0)
-				sql += ", ";
-			sql += "?";
+				sql.append(", ");
+			sql.append('?');
 		}
-		sql += ")";
-		return sql;
+		sql.append(')');
+		return sql.toString();
 	}
 	
 	private void generateInsert(PreparedStatement insert, String [] types, String [] data) throws SQLException {
@@ -191,9 +197,9 @@ public class RelationalServerData extends RelationalDatabase {
 			if (types[i].startsWith("TEXT"))
 				insert.setString(i+1, data[i]);
 			else if (types[i].startsWith("REAL"))
-				insert.setDouble(i+1, Double.valueOf(data[i]));
+				insert.setDouble(i+1, Double.parseDouble(data[i]));
 			else if (types[i].startsWith("INTEGER"))
-				insert.setLong(i+1, Long.valueOf(data[i]));
+				insert.setLong(i+1, Long.parseLong(data[i]));
 			else
 				throw new SQLException("Data type unsupported by sdb/sqlite! Type: " + types[i]);
 		}