When you join a faction, #16 is set to true.
When you go combatant, #32 is set to true. The resulting flag: 48
When you go SF, #1, #2 and #4 are set to true. The resulting flag: 55
When you go back to combatant, #1, #2 and #4 are set to false. The resulting flag: 48
The error was either in the Player flag not being set anywhere, or setPvpStatus setting it instead of doing OR/XOR operations.
(The result of this would be bit #16 wouldn't be set to true, meaning SF would be 39 instead of 55)
We could still set all of the flags to true for SF without harm for safety, it just wasn't theoretically necessary.
Additionally any players that login automatically were getting #16 sent to the client by sendBaselines() regardless of if they had a faction, which should now be fixed.
(BugFix) /showhelmet and /showbackpack works and helmet/backpacks now
showed for the person wearing the item
(Code) Server will store player creation date for future use in baseline
(BugFix) Fixed out of bounds error when assigning expertise points
(Code) Changed SkillMod's modifier variable to float value
(Code) Changed Charge! and Scatter! to use updated addBuffToCreature
(BugFix) Officer group buff's will now check ranges
(BugFix) Group buffs applied when a player joins a group as long as they
are within range
(BugFix) /inspire will now take a command string for target
(BugFix) /imagedesign will now take a command string for target
(Bug) Fixed hair and items on char create not being added to equip list
(Code) Minor change to BuffBuilderMessage
(Code) Added base work for Image Design
(Code) Refactored how starter clothing is assigned
(Code) Added delta for customization data on tangible objects
(Code) Created ProfessionTemplateVisitor for profession template iff's
Line 1181 in CreatureMessageBuilder needs to be uncommented. When it is,
after a couple skill mod delta's are sent, a crash occurs. I'm unsure on
how to fix it.
(Added) Entertainers can now add Cover Charges for their performance
(Feature) Using a performance effect that has multiple effect levels
will use the highest effect for the entertainers level
(Code) Added 2 new methods (Jython and Java version) for Input Boxes
that automatically adds the input text to return list.
(Code) Moved essential spectating code from /watch script to
startSpectating
(BugFix) Fixed Null Error when trying to cancel Experience tick if
leveled with a cheat.
(BugFix) Fixed system messages error on performance abilities
Skills obtained through the expertise system are now validated to make
sure they are legitimate expertise skills.
Player expertise points are also now factored in instead of letting the
client do all the calculations.
Command "setcurrentskilltitle" now checks if the player has obtained the
skill title to prevent abuse of the command.
Treeku