Removed variable declaration, duplicate playerLaugh and unneeded check if the player doesn't have the buff. Moved playerLaugh to play regardless as its what is intended.
Thanks to Aconite for helping me spot these.
Adjusts Ponda Baba's arm in the master item list to reflect how it was on live, this removes the autostack and 1 time use it previously had. Implemented script side for the spooky hand buff so it correctly gives bonus tokens as it did on live (+1 token per successful horrified scare and +2 tokens per successful terrified scare).
Small adjustment here to make this more logical, show "Lava Resistance: 100%" attribute if the template already has resistance OR if the lava resistance kit has been used on the vehicle, not just if the kit has been used.
This bug-fixes a few things and replaces some stuff:
* The old defaultLoad TreeSet where you needed to manually add each script to the default load list has been replaced with a dynamic solution so modifying this in the future each time a base script class is added should be unnecessary (also it's an immutable HashSet now because there's no reason for it to be a TreeSet).
* Likewise, adding inner classes (and enums) to library scripts not in the default load should no longer fail to load during the normal loading process nor should it cause ClassNotFound/NoClassDefError/NoSuchMethodException errors.
* Fixed a bunch of raw use of parameterized class warnings.
* Set DEBUG = true for native java logging API to log everything happening here since it's a bit awkward to try and log through base_class.LOG when we haven't loaded it yet, so a tiny custom logging implementation has been added.
* Cleaned up so it's a bit more readable and easier to customize how we were checking if a class was from Java/JDK for the default load process, and also flagged that if you need to add custom libraries, you can just throw the class prefix into the new array and then include the lib in whatever you're doing.
* Switched RandomAccessFile.read() to .readFully() since that is available now and it does the same thing as what we were doing but more clearly.
Restructures WoD Plants/Trees to be more coherent and in keeping with how they were on live. Removes prologue tree 09-12 as they are actually "potted plants" per EoL and awarded through the themepark rather than the prologue.
Corrected the generic themepark herb jar which was previously using the nightsister jar appearance.
Updated other herb jars to use the correct names they used on live and updated the rewards.tab to correspond. The generics were already their correct names, so the quest tabs do not need to be updated.
Updated all herb jars to use correct scripts and updated scripts to correctly award the proper trees/plants.
Removed any incorrect or redundant objects.
Since information is very hard to find I've included it in this commit.
Prologue Trees 1-8 are awarded via the prologue seed jar.
Nightsister & Singing Mountain Prologue Trees 1-8 are awarded via the prologue collection for Nightsisters.
Potted Plants 1-9 are awarded via the Witches of Dathomir seed jar.
Nightsister & Singing Mountain Potted Plants 1-9 are awarded via the collections for the main Themepark herb delivery quests, which also gives a seed jar for the respective faction.
tl;dr tress are prologue and potted plants are part of the main themepark.
AconiteX