theoretically this helps performance

engine/shared/library/sharedFile/src/shared/FileStreamer.cpp

@@ -229,7 +229,7 @@ int FileStreamer::File::read(int offset, void *destinationBuffer, int numberOfBy
 	newRequest->bytesRead      = 0;
 	newRequest->gate           = gate;
 	newRequest->priority       = priority;
-	newRequest->returnValue    = returnValue;
+	newRequest->returnValue    = &returnValue;
 
 	// submit the request
 	FileStreamerThread::submitRequest(newRequest);

external/3rd/library/platform/utils/Base/MD5.cpp

@@ -52,7 +52,7 @@ namespace Base
         Update(input);
     }
 
-    vector<int> MD5::Decode(vector<char> achar0, int i, int j)
+	vector<int> MD5::Decode(const vector<char> &achar0, int i, int j)
     {
         vector<int> ai(16,0);
         int l;
@@ -66,9 +66,9 @@ namespace Base
         return ai;
     }
 
-    vector<char> MD5::Encode(vector<int> ai, int i)
+    vector<char> MD5::Encode(const vector<int> &ai, int i)
     {
-        vector<char> achar0(i,0);
+        const vector<char> &achar0(i,0);
         int k;
         int j = k = 0;
         for(; k < i; k += 4){
@@ -93,7 +93,7 @@ namespace Base
         if (finalsNull)
         {
             State &state1 = state;
-            vector<char> achar0 = Encode(state1.count, 8);
+            const vector<char> &achar0 = Encode(state1.count, 8);
             int i = state1.count[0] >> 3 & 0x3f;
             int j = i >= 56 ? 120 - i : 56 - i;
             Update(state1, padding, 0, j);
@@ -132,7 +132,7 @@ namespace Base
         finalsNull = true;
     }
 
-    void MD5::Transform(State & state1, vector<char> achar0, int i)
+    void MD5::Transform(State & state1, const vector<char> &achar0, int i)
     {
         int j = state1.state[0];
         int k = state1.state[1];
@@ -211,12 +211,12 @@ namespace Base
 
     void MD5::Update(char char0)
     {
-        vector<char> achar0(1,0);
+        const vector<char> &achar0(1,0);
         achar0[0] = char0;
         Update(achar0, 1);
     }
 
-    void MD5::Update(State & state1, vector<char> achar0, int i, int j)
+    void MD5::Update(State & state1, const vector<char> &achar0, int i, int j)
     {
         finalsNull = true;
         if (j - i > (int)achar0.size())
@@ -258,17 +258,17 @@ namespace Base
         Update( achar, achar.size() );
     }
 
-    void MD5::Update(vector<char> achar0)
+    void MD5::Update(const vector<char> &achar0)
     {
         Update(achar0, 0, achar0.size());
     }
 
-    void MD5::Update(vector<char> achar0, int i)
+    void MD5::Update(const vector<char> &achar0, int i)
     {
         Update(state, achar0, 0, i);
     }
 
-    void MD5::Update(vector<char> achar0, int i, int j)
+    void MD5::Update(const vector<char> &achar0, int i, int j)
     {
         Update(state, achar0, i, j);
     }
@@ -278,7 +278,7 @@ namespace Base
         return asHex(Final());
     }
 
-    string MD5::asHex(vector<char> achar0)
+    string MD5::asHex(const vector<char> &achar0)
     {
         const string hex = "0123456789abcdef";
 

external/3rd/library/platform/utils/Base/MD5.h

@@ -36,22 +36,22 @@ namespace Base
             void Init();
             std::vector<char> Final();
             void Update(char char0);
-            void Update(State & state1, std::vector<char> achar0, int i, int j);
+            void Update(State & state1, const std::vector<char> &achar0, int i, int j);
             void Update(std::string s);
-            void Update(std::vector<char> achar0);
-            void Update(std::vector<char> achar0, int i);
-            void Update(std::vector<char> achar0, int i, int j);
+            void Update(const std::vector<char> &achar0);
+            void Update(const std::vector<char> &achar0, int i);
+            void Update(const std::vector<char> &achar0, int i, int j);
             std::string asHex();
-            static std::string asHex(std::vector<char> achar0);
+            static std::string asHex(const std::vector<char> &achar0);
 
         private:
-            std::vector<int> Decode(std::vector<char> achar0, int i, int j);
-            std::vector<char> Encode(std::vector<int> ai, int i);
+            std::vector<int> Decode(const std::vector<char> &achar0, int i, int j);
+            std::vector<char> Encode(const std::vector<int> &ai, int i);
             int FF(int i, int j, int k, int l, int i1, int j1, int k1);
             int GG(int i, int j, int k, int l, int i1, int j1, int k1);
             int HH(int i, int j, int k, int l, int i1, int j1, int k1);
             int II(int i, int j, int k, int l, int i1, int j1, int k1);
-            void Transform(State & state1, std::vector<char> achar0, int i);
+            void Transform(State & state1, const std::vector<char> &achar0, int i);
             int rotate_left(int i, int j);
             int uadd(int i, int j);
             int uadd(int i, int j, int k);

external/3rd/library/soePlatform/VChatAPI/utils2.0/utils/Base/monitorData.cpp

@@ -326,6 +326,8 @@ int x;
 		return 0;
 	}
 
+	size_t desP1 = (strlen(des) + 1);
+
 	for(x=0;x<m_count;x++)
 	{
 		if( id == m_data[x].id )
@@ -345,9 +347,10 @@ int x;
 			if( m_data[x].discription != NULL )
 				delete [] m_data[x].discription;
 			m_data[x].discription = NULL;
+			
 			if( des )
 			{
-				m_data[x].discription = new char [strlen(des)+1];
+				m_data[x].discription = new char[desP1];
 				strcpy(m_data[x].discription,des);
 			}
 			m_sort = 1;
@@ -386,6 +389,8 @@ int x;
 int CMonitorData::setDescription( int Id, const char *Description , int & mode) 
 {
 int x;
+	
+	size_t sDescP1 = (strlen(Description) + 1);
 
 	for(x=0;x<m_count;x++)
 	{
@@ -404,7 +409,7 @@ int x;
 
 			if( m_data[x].discription )
 				delete [] m_data[x].discription;
-			m_data[x].discription = new char [ strlen(Description) +1 ];
+			m_data[x].discription = new char [ sDescP1 ];
 			strcpy(m_data[x].discription,Description);
 			mode = 1;					
 			return x;